Skip to content

systemvm: don't fork to curl to save password#3437

Merged
yadvr merged 2 commits into
apache:masterfrom
shapeblue:non-forking-password-saving
Jul 1, 2019
Merged

systemvm: don't fork to curl to save password#3437
yadvr merged 2 commits into
apache:masterfrom
shapeblue:non-forking-password-saving

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Jun 28, 2019

This fixes to avoid forking curl to save password but instead call
a HTTP POST url directly within Python code. This may reduce bottleneck
during high VM launches that require passwords.

Fixes #3182

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This fixes to avoid forking curl to save password but instead call
a HTTP POST url directly within Python code. This may reduce bottleneck
during high VM launches that require passwords.

Fixes apache#3182

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 28, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-55

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 28, 2019

Can you review this @shwstppr @anuragaw

Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 28, 2019

Tested by deploying macchnina with password script, feature works ok, no regressions seen.
@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 29, 2019

Env issue rekicking
@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@apache apache deleted a comment from blueorangutan Jul 1, 2019
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jul 1, 2019

Re-kicked trillian job

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-74)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28562 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3437-t74-kvm-centos7.zip
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 2ecd5ec into apache:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve password saving to VR password server without forking processes

5 participants