Skip to content

travis: use openjdk8 and xenial (ubuntu 16.04)#3466

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:openjdk-travis-fix
Jul 4, 2019
Merged

travis: use openjdk8 and xenial (ubuntu 16.04)#3466
yadvr merged 1 commit into
apache:4.11from
shapeblue:openjdk-travis-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Jul 4, 2019 •
edited
Loading

This fixes Travis to use openjdk8 and Xenial (Ubuntu 16.04) as base
distro.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This only changes Travis config and does not require smoketests. PR may be merged solely when Travis passes.

@yadvr
travis: use openjdk8 and xenial (ubuntu 16.04)
1fb193f 
This fixes Travis to use openjdk8 and Xenial (Ubuntu 16.04) as base
distro.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.13.0.0 milestone Jul 4, 2019
shwstppr
shwstppr approved these changes Jul 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on changes.

anuragaw
anuragaw approved these changes Jul 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on code but should wait for travis to finish tasks on the PR before merge perhaps

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jul 4, 2019

Merging this based on Abhishek and Anurag's LGTM and Travis passed.

Screenshot from 2019-07-04 15-29-36

@yadvr yadvr merged commit 35b9145 into apache:4.11 Jul 4, 2019
borisstoyanov
borisstoyanov approved these changes Jul 4, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yadvr added a commit that referenced this pull request Jul 24, 2019
@yadvr
engine/storage: remove unused import
d930982 
Fixes checkstyle issue caused by previous commit 6a511fc
from PR #3466 where a minor review fix did not address this. Merging this
one to unblock few other PRs after running a local build test.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@DennisKonrad DennisKonrad Awaiting requested review from DennisKonrad

@GabrielBrascher GabrielBrascher Awaiting requested review from GabrielBrascher

@kiwiflyer kiwiflyer Awaiting requested review from kiwiflyer

@nathanejohnson nathanejohnson Awaiting requested review from nathanejohnson

@nvazquez nvazquez Awaiting requested review from nvazquez

@PaulAngus PaulAngus Awaiting requested review from PaulAngus

@rafaelweingartner rafaelweingartner Awaiting requested review from rafaelweingartner

@svenvogel svenvogel Awaiting requested review from svenvogel

@wido wido Awaiting requested review from wido

+1 more reviewer

@anuragaw anuragaw anuragaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:travis Severity:BLOCKER

Projects

None yet

Milestone

4.13.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @shwstppr @borisstoyanov @anuragaw