Skip to content

allocator: in case of null guest OS don't fail prioritisation completely#3607

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:npe-altfix
Sep 26, 2019
Merged

allocator: in case of null guest OS don't fail prioritisation completely#3607
yadvr merged 1 commit into
apache:masterfrom
shapeblue:npe-altfix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Sep 25, 2019

In case of null guest OS found for a template, don't fail prioritisation
completely (could still work based on HVM etc).

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@yadvr
allocator: in case of null guest OS don't fail prioritisation completely
6f76d8f 
In case of null guest OS found for a template, don't fail prioritisation
completely (could still work based on HVM etc).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.14.0.0 milestone Sep 25, 2019
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Sep 25, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 25, 2019

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 25, 2019

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-289

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Sep 25, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 25, 2019

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 25, 2019

Trillian test result (tid-383)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34679 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3607-t383-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

shwstppr
shwstppr approved these changes Sep 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anuragaw
anuragaw approved these changes Sep 26, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@anuragaw anuragaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from code and description. Haven't tested.

@yadvr yadvr merged commit 6cec7c7 into apache:master Sep 26, 2019
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@yadvr @ustcweizhou
allocator: in case of null guest OS don't fail prioritisation complet…
3289285 
…ely (apache#3607)

In case of null guest OS found for a template, don't fail prioritisation
completely (could still work based on HVM etc).

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

+1 more reviewer

@anuragaw anuragaw anuragaw approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Severity:Minor type:bug

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @blueorangutan @shwstppr @anuragaw