systemvm: for ip route show command don't use the throw command#3612
Conversation
While searching for existing route, don't use the throw keyword when using the cmd with `ip route show`. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-301 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-395)
|
|
Can you review this @ustcweizhou ? Thanks. |
|
LGTM |
|
@andrijapanicsb can you review? this is the bug that cause errors in the /var/log/cloud.log for a VR when it runs command to show/check if a route exists (doesn't actually cause any VR issues/failure, but causes errors in the log) |
|
@andrijapanicsb can you review this? Thanks. |
andrijapanicsb
left a comment
There was a problem hiding this comment.
LGTM - tested manually, and the specific error is not there.
While searching for existing route, don't use the throw keyword when
using the cmd with
ip route show. This fixes unnecessary ERROR messages in the VR cloud.log and issue of re-adding an already added routing rule (which may throw RTLINK file already exists error).Types of changes