Revert "Simulator: Better VR Redundant Status Behaviour"#3796
Merged
Conversation
This reverts commit d868cd1.
yadvr
approved these changes
Jan 7, 2020
Member
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
Yes based on quick git bisect/triaging the PR introduced Travis failures and broke master/travis. Once it is revised and properly fixed, this can be accepted.
Member
|
PR Travis job has passed, this can be merged after a review @andrijapanicsb @DaanHoogland cc @PaulAngus @borisstoyanov . |
andrijapanicsb
approved these changes
Jan 8, 2020
Contributor
andrijapanicsb
left a comment
andrijapanicsb
left a comment
There was a problem hiding this comment.
I belive the same kind of comments were originally left in the original PR.
Reverting @richardlawley kindly "fix" the stuff in new PR, so we can accept those changes. Thx
anuragaw
approved these changes
Jan 8, 2020
ustcweizhou
pushed a commit
to ustcweizhou/cloudstack
that referenced
this pull request
Feb 28, 2020
apache#3796) This reverts commit d868cd1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3313
@richardlawley it seems your PR gives unexpected CI problems, we have to revert. can you investigate and re-submit?