Skip to content

UI: Display drop down list for VPN customer gateway selection#3805

Merged
yadvr merged 1 commit into
apache:masterfrom
ravening:ui_vpn_gateway
Feb 7, 2020
Merged

UI: Display drop down list for VPN customer gateway selection#3805
yadvr merged 1 commit into
apache:masterfrom
ravening:ui_vpn_gateway

Conversation

@ravening
Copy link
Copy Markdown
Member

@ravening ravening commented Jan 13, 2020

Description

Display drop-down list for VPN customer gateway selection in UI so that it can be searched according to domains

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Before the change, there was no drop down list for domains

Screenshot 2020-01-13 at 14 49 24

After the change there is a drop down and the domains are displayed in the sorted order

Screenshot 2020-01-13 at 14 50 09

How Has This Been Tested?

@yadvr yadvr added this to the 4.14.0.0 milestone Jan 20, 2020
@ravening
UI: Display drop down list for VPN customer gateway selection
ae55705 
Display drop-down list for VPN customer gateway selection in UI
so that it can be searched according to domains
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jan 30, 2020

pure UI change.
LGTM

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 30, 2020

@ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?

@ravening
Copy link
Copy Markdown
Member Author

ravening commented Jan 30, 2020

@ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?

@DaanHoogland Just to confirm, are you saying all the future Ui pr's should be raised again primate and not here?

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jan 30, 2020

@ravening I see your use case and do approve. Could you please keep in mind that this UI is phased out and create a primate ticket?

@DaanHoogland Just to confirm, are you saying all the future Ui pr's should be raised again primate and not here?

No, not at the moment. I am saying that primate is planned to replace the UI as the standard UI in 4.15. It is still in alpha mode so it may take a while. but when voted on primate will probably be the only UI maintained and whether it will be part of this project is to be decided but very likely, so in that case PRs for UI will still be here!

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 31, 2020

Can anyone confirm manual testing?

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jan 31, 2020

Can anyone confirm manual testing?

I have manually tested it

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 7, 2020

Merging this based on @weizhouapache 's manual tests, code lgtm.

@yadvr yadvr merged commit c6e67c4 into apache:master Feb 7, 2020
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@ravening @ustcweizhou
ui: display drop down list for VPN customer gateway selection (apache…
b175b99 
…#3805)

Display drop-down list for VPN customer gateway selection in UI
so that it can be searched according to domains
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

Assignees

No one assigned

Labels

component:UI type:enhancement

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ravening @weizhouapache @DaanHoogland @yadvr @svenvogel