Enhancement: Allow creating network with duplicate name by ravening · Pull Request #3807 · apache/cloudstack

ravening · 2020-01-13T17:30:26Z

Add a global setting to disable creating networks with
same name in an account

Add a global setting to disable creating network without
mentioning the start and end IPv4 or IPv6 address

Description

By default we can create networks with the same name in the account. Sometimes we should not create the networks with same name. This change adds a global setting which prevents creating the network with same name. The default value is true and set it to false to prevent creating network with same names.

Also its possible to create a shared network without mentioning the start and the end IPv4 or IPv6 address. This change adds a global setting which prevents creating a shared network without specifying the start and the end IPv4 or IPv6 address

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Creating a network with same names
1 . Set the global setting allow.duplicate.networkname to true
2. Create a new network with the name "test".
3. Try to create another network with the same name. This should create the second network with the same name
4. Now set the above global setting value to false
5. Try to create another network with same name.
6. No exception will be thrown while creating the network with same name

Creating a network without specifying the start and end IPv4 or IPv6 address

Set the global setting allow.empty.start.end.ipaddress to true
Create a shared network without mentioning the start and the end IPv4 or IPv6 address
You will be able to create network successfully
Now set the above global setting value to false
Try to create another shared network without mentioning the start or the end IPv4 or IPv6 address
An exception will be thrown while creating the shared network

DaanHoogland

nioce code
tests included
pudding needs eating

wido

LGTM based on code

ravening · 2020-01-21T13:33:09Z

@DaanHoogland can this be merged?

DaanHoogland · 2020-01-22T17:25:58Z

@blueorangutan package

blueorangutan · 2020-01-22T17:26:51Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

DaanHoogland · 2020-01-22T17:29:47Z

@ravening "pudding needs eating" so i am starting a full regression suite. (if it comes back good i'm fine with it.)

blueorangutan · 2020-01-22T17:50:03Z

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-652

DaanHoogland · 2020-01-22T18:07:58Z

@blueorangutan test

blueorangutan · 2020-01-22T18:08:51Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-01-23T03:32:41Z

Trillian test result (tid-810)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31865 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3807-t810-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2020-01-23T13:34:02Z

I am not investing time in testing this now, but regrtession passes on all platforms. feel free to merge, @wido @weizhouapache ?

yadvr · 2020-01-28T05:48:05Z

+            "allow.duplicate.networkname", "true", "Allow creating networks with same name in account", true, ConfigKey.Scope.Account);
+    private static final ConfigKey<Boolean> AllowEmptyStartEndIpAddress = new ConfigKey<Boolean>("Advanced", Boolean.class,
+            "allow.empty.start.end.ipaddress", "true", "Allow creating network without mentioning start and end IP address",
+            true, ConfigKey.Scope.Account);


@ravening for backward compatibility, should this be false?

@rhtyd In the current/default behavior we can create network without mentioning the start and end IP address. So the default value is "true". If the default value is "false" then it means we cant create a network with an empty start and end IP address which is not backward compatible.

yadvr · 2020-01-29T10:01:32Z

@ravening if the newly added test test/integration/component/test_network_create_with_dup_name.py does not take more than 5-10mins to run, please move it under smoke and also add to Travis (see `.travis.yml).

Add a global setting to disable creating networks with same name in an account Add a global setting to disable creating network without mentioning the start and end IPv4 or IPv6 address By default we can create networks with the same name in the account. Sometimes we should not create the networks with same name. This change adds a global setting which prevents creating the network with same name. The default value is true and set it to false to prevent creating network with same names. Also its possible to create a shared network without mentioning the start and the end IPv4 or IPv6 address. This change adds a global setting which prevents creating a shared network without specifying the start and the end IPv4 or IPv6 address

ravening · 2020-01-30T09:00:42Z

@ravening if the newly added test test/integration/component/test_network_create_with_dup_name.py does not take more than 5-10mins to run, please move it under smoke and also add to Travis (see `.travis.yml).

@rhtyd moved the marvin test to smoke folder and added an entry in travis.yml as well

yadvr · 2020-01-31T09:46:43Z

Thanks @ravening I'll merge this as soon as Travis (simulator) passes (rekicked the job).

Add a global setting to disable creating networks with same name in an account Add a global setting to disable creating network without mentioning the start and end IPv4 or IPv6 address By default we can create networks with the same name in the account. Sometimes we should not create the networks with same name. This change adds a global setting which prevents creating the network with same name. The default value is true and set it to false to prevent creating network with same names. Also its possible to create a shared network without mentioning the start and the end IPv4 or IPv6 address. This change adds a global setting which prevents creating a shared network without specifying the start and the end IPv4 or IPv6 address

svenvogel added component:networking type:enhancement labels Jan 13, 2020

DaanHoogland reviewed Jan 14, 2020

View reviewed changes

Comment thread server/src/main/java/com/cloud/network/NetworkServiceImpl.java Outdated

ravening force-pushed the network_enhancements branch from 17b087d to 43a5b71 Compare January 14, 2020 13:19

DaanHoogland approved these changes Jan 14, 2020

View reviewed changes

wido self-requested a review January 15, 2020 20:19

wido approved these changes Jan 15, 2020

View reviewed changes

apache deleted a comment from blueorangutan Jan 22, 2020

yadvr reviewed Jan 28, 2020

View reviewed changes

ravening force-pushed the network_enhancements branch from 43a5b71 to 8525f77 Compare January 30, 2020 08:59

yadvr approved these changes Jan 31, 2020

View reviewed changes

yadvr added this to the 4.14.0.0 milestone Jan 31, 2020

yadvr merged commit a2a4968 into apache:master Jan 31, 2020

weizhouapache mentioned this pull request Dec 4, 2020

Incorrect isolated network creation #3513

Closed

Conversation

ravening commented Jan 13, 2020

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

wido left a comment

Choose a reason for hiding this comment

Uh oh!

ravening commented Jan 21, 2020

Uh oh!

DaanHoogland commented Jan 22, 2020

Uh oh!

blueorangutan commented Jan 22, 2020

Uh oh!

DaanHoogland commented Jan 22, 2020

Uh oh!

blueorangutan commented Jan 22, 2020

Uh oh!

DaanHoogland commented Jan 22, 2020

Uh oh!

blueorangutan commented Jan 22, 2020

Uh oh!

blueorangutan commented Jan 23, 2020

Uh oh!

DaanHoogland commented Jan 23, 2020

Uh oh!

yadvr Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

ravening Jan 28, 2020

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jan 29, 2020

Uh oh!

ravening commented Jan 30, 2020

Uh oh!

yadvr commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants