Skip to content

kvm-local-pool-trailing-slash#3813

Merged
yadvr merged 1 commit into
masterfrom
kvm-local-pool-trailing-slash1
Jan 28, 2020
Merged

kvm-local-pool-trailing-slash#3813
yadvr merged 1 commit into
masterfrom
kvm-local-pool-trailing-slash1

Conversation

@andrijapanicsb
Copy link
Copy Markdown
Contributor

@andrijapanicsb andrijapanicsb commented Jan 14, 2020

Description

Stop asking user (in the upgrade documentation) to remove a trailing slash for local KVM pool - do it here in upgrade path - so not needed in DOC for the upgrade to 4.14 and onwards.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is fine of course, but i wonder if this was put there on purpose, back in the days. let's adventure.

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 16, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-612

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 20, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-793)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37771 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3813-t793-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 77 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_05_rvpc_multi_tiers Failure 418.28 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 444.61 test_vpc_redundant.py

@yadvr yadvr merged commit 0095272 into master Jan 28, 2020
@andrijapanicsb andrijapanicsb deleted the kvm-local-pool-trailing-slash1 branch April 3, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants