Skip to content

ISSUE-3838: Wrong SSVM behavior causes redownloading for all the templates#3844

Merged
yadvr merged 1 commit into
apache:masterfrom
bwsw:bugfix/3838-script-wrong-behavior
Feb 7, 2020
Merged

ISSUE-3838: Wrong SSVM behavior causes redownloading for all the templates#3844
yadvr merged 1 commit into
apache:masterfrom
bwsw:bugfix/3838-script-wrong-behavior

Conversation

@bwsw
Copy link
Copy Markdown
Contributor

@bwsw bwsw commented Jan 28, 2020

As per discussion at #3838 and proposal by @weizhouapache this PR implements the fix.

#3838

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

How Has This Been Tested?

tested manually

@bwsw bwsw changed the title Fixes #3838 ISSUE-3838: Wrong SSVM behavior causes redownloading for all the templates Jan 28, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 28, 2020

@bwsw is this ready for review/testing?

@bwsw
Copy link
Copy Markdown
Contributor Author

bwsw commented Jan 28, 2020

@rhtyd yep

weizhouapache
weizhouapache approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually.

@yadvr yadvr closed this Jan 29, 2020
@yadvr yadvr reopened this Jan 29, 2020
@yadvr yadvr requested a review from DaanHoogland January 30, 2020 17:00
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 31, 2020

@bwsw can you fix the conflict?

@bwsw
Copy link
Copy Markdown
Contributor Author

bwsw commented Jan 31, 2020

@rhtyd done

@apache apache deleted a comment from yadvr Jan 31, 2020
@apache apache deleted a comment from blueorangutan Jan 31, 2020
@apache apache deleted a comment from blueorangutan Jan 31, 2020
@apache apache deleted a comment from yadvr Jan 31, 2020
@apache apache deleted a comment from blueorangutan Jan 31, 2020
@apache apache deleted a comment from blueorangutan Jan 31, 2020
DaanHoogland
DaanHoogland requested changes Jan 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of renaming and reformatting in comparison, but those are all good. just one rebase error s_logger should be LOGGER.
logic is sane afaict

Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
Comment thread ...storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java Outdated
@bwsw
Copy link
Copy Markdown
Contributor Author

bwsw commented Feb 3, 2020

@DaanHoogland fixed.

@yadvr yadvr closed this Feb 5, 2020
@yadvr yadvr reopened this Feb 5, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 5, 2020

@blueorangutan package

yadvr
yadvr approved these changes Feb 5, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did not test it though. Need to test all three hypervisors (template types)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 5, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 5, 2020

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr yadvr added this to the 4.14.0.0 milestone Feb 5, 2020
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 5, 2020

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-749

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Feb 6, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 6, 2020

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 7, 2020

Trillian test result (tid-908)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41905 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3844-t908-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_privategw_static_routes Failure 493.32 test_privategw_acl.py

@yadvr yadvr merged commit f78cbf4 into apache:master Feb 7, 2020
ustcweizhou pushed a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
@bwsw @ustcweizhou
ssvm: wrong SSVM behavior causes redownloading for all the templates (a…
0c5f62c 
…pache#3844)

As per discussion at apache#3838 and proposal by @weizhouapache this PR implements the fix.

Fixes apache#3838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:ssvm type:bug

Projects

None yet

Milestone

4.14.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bwsw @yadvr @blueorangutan @DaanHoogland @weizhouapache @svenvogel