Skip to content

vr: fix vr in unknown state (more)#3848

Merged
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-vr-redundant-state
Jan 30, 2020
Merged

vr: fix vr in unknown state (more)#3848
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-vr-redundant-state

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

@ustcweizhou ustcweizhou commented Jan 28, 2020

Description

This fixes similar issue with #3465

Meanwhile change log level of CsHelper.execute2 from DEBUG to INFO and fix some typo

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

@DaanHoogland
Copy link
Copy Markdown
Contributor

code lgtm but it is only an improvement, is that right @weizhouapache or does it really solve a bug?

@weizhouapache
Copy link
Copy Markdown
Member

@DaanHoogland I believe there are some issues caused by this when vpc has more than 10 tiers.
This change in STATE_COMMANDS is similar as #3465 which should be a bug fix.

The change on log level can be regarded as an improvement.

@yadvr yadvr added this to the 4.13.1.0 milestone Jan 29, 2020
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the syntax to show dev is correct

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 29, 2020

@blueorangutan package

@yadvr yadvr closed this Jan 29, 2020
@yadvr yadvr reopened this Jan 29, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 29, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-682

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland I believe there are some issues caused by this when vpc has more than 10 tiers.

grep eth10 or -eth11 etc, got it thanks @weizhouapache

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jan 29, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-843)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38301 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3848-t843-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_redundant_vpc_site2site_vpn Failure 391.31 test_vpc_vpn.py

@yadvr yadvr merged commit 521217c into apache:4.13 Jan 30, 2020
ustcweizhou added a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
This fixes similar issue with apache#3465.

Meanwhile change log level of CsHelper.execute2 from DEBUG to INFO and fix some typo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants