Skip to content

kvm: Fix router migration issue when router has control/public nics onother physical network than guest#3855

Merged
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-kvm-migration-issue-multiple-physical-networks
Jan 31, 2020
Merged

kvm: Fix router migration issue when router has control/public nics onother physical network than guest#3855
yadvr merged 1 commit into
apache:4.13from
ustcweizhou:4.13-kvm-migration-issue-multiple-physical-networks

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

Description

In VM migration on KVM, libvirt qemu hook script will change the bridge name to bridges for guest networks. It works for user vm. However for virtual router, it has nics on control network and public network. If control/public use different physical networks than guest network, virtual router cannot be migrated.

Fixes: #2783

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

We have more than 1 physical networks and faced same issue before.
We have this change to fix the issue in old cloudstack versions.
I did not test in latest master or 4.13 but I believe it should work as well.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-720

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-864)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3855-t864-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland requested a review from yadvr January 31, 2020 07:46
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland DaanHoogland requested review from DaanHoogland, andrijapanicsb and borisstoyanov and removed request for DaanHoogland January 31, 2020 07:47
@yadvr yadvr added this to the 4.13.1.0 milestone Jan 31, 2020
@yadvr yadvr merged commit 76fb811 into apache:4.13 Jan 31, 2020
ustcweizhou added a commit to ustcweizhou/cloudstack that referenced this pull request Feb 28, 2020
…n other physical network than guest (apache#3855)

In VM migration on KVM, libvirt qemu hook script will change the bridge name to bridges for guest networks. It works for user vm. However for virtual router, it has nics on control network and public network. If control/public use different physical networks than guest network, virtual router cannot be migrated.

Fixes: apache#2783
Slair1 pushed a commit to ippathways/cloudstack that referenced this pull request May 12, 2021
…n other physical network than guest (apache#3855)

In VM migration on KVM, libvirt qemu hook script will change the bridge name to bridges for guest networks. It works for user vm. However for virtual router, it has nics on control network and public network. If control/public use different physical networks than guest network, virtual router cannot be migrated.

Fixes: apache#2783
Slair1 pushed a commit to ippathways/cloudstack that referenced this pull request May 12, 2021
…n other physical network than guest (apache#3855)

In VM migration on KVM, libvirt qemu hook script will change the bridge name to bridges for guest networks. It works for user vm. However for virtual router, it has nics on control network and public network. If control/public use different physical networks than guest network, virtual router cannot be migrated.

Fixes: apache#2783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants