Fix delete network with no services

[nvazquez]

Description

Fix dele shared network with no services on network offering
Fixes: #4096

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Create network offering with no services
Create network from offering
Deploy VM
Delete network

[yadvr]

Did not test, @nvazquez please kick packaging and tests yourself

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1315

[nvazquez]

@blueorangutan test matrix

[blueorangutan]

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1388

[blueorangutan]

Packaging result: ✔centos7 ✔debian. JID-1386

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[nvazquez]

@borisstoyanov @andrijapanicsb @rhtyd I've checked the test environment and it ended up with a disabled zone and no system VMs, had to manually enable the zone back. Do you remember which test caused this failure?

[yadvr]

@nvazquez you can check yourself:

$ cd test/integration/smoke
$ grep updateZone -R .

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1748)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31340 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4132-t1748-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	244.73	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	190.75	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	265.85	test_privategw_acl.py

[yadvr]

Ping @borisstoyanov @andrijapanicsb @DaanHoogland

[DaanHoogland]

what this does is make sure that nics with no IP are only search when a network is L2 and has no services. The code looks good and it might be a valid fix but the description doesn't allign with the content of the change. I can not judge this.

[borisstoyanov]

LGTM