Incorrect md5sums for systemVM templates results in failure to download templates to other image stores

[Pearl1594]

Description

Incorrect checksums for systemVM template along the 4.13.1 to 4.14 upgrade path, causes failure in downloading/ syncing the systemVM templates on other / newly added image stores

Steps to reproduce

1. Deploy a 4.14 setup - with a single image store
2. Once the env is up and running, add another image store
3. When the template sync happens on the newly added image store, the systemVM template fails the checksum verification

*************************** 4. row ***************************
                  id: 23
            store_id: 2
         template_id: 3
             created: 2020-07-13 10:07:49
        last_updated: 2020-07-13 10:08:22
              job_id: 099eeb3a-c980-4dc6-8e00-28203c59feef
        download_pct: 100
                size: 0
          store_role: Image
       physical_size: 0
      download_state: DOWNLOAD_IN_PROGRESS
           error_str: Download success, starting install 
          local_path: /mnt/SecStorage/32ea45f5-76bb-3b1f-ac10-6aa9939f771f/template/tmpl/1/3/dnld5468597899343935001tmp_
        install_path: template/tmpl/1/3
                 url: NULL
               state: Creating
           destroyed: 0
             is_copy: 0
        update_count: 1
             ref_cnt: 0
             updated: 2020-07-13 10:07:49
download_url_created: NULL
        download_url: NULL
4 rows in set (0.00 sec)


*************************** 4. row ***************************
                  id: 23
            store_id: 2
         template_id: 3
             created: 2020-07-13 10:07:49
        last_updated: 2020-07-13 10:08:43
              job_id: 099eeb3a-c980-4dc6-8e00-28203c59feef
        download_pct: 100
                size: 0
          store_role: Image
       physical_size: 0
      download_state: DOWNLOAD_ERROR
           error_str: Failed post download script: checksum "{MD5}4978e6e6140d167556f201496549a498" didn't match the given value, "{MD5}d15ed159be32151b07e3211caf9cb802"
          local_path: /mnt/SecStorage/32ea45f5-76bb-3b1f-ac10-6aa9939f771f/template/tmpl/1/3/dnld5468597899343935001tmp_
        install_path: template/tmpl/1/3
                 url: NULL
               state: Allocated
           destroyed: 0
             is_copy: 0
        update_count: 2
             ref_cnt: 0
             updated: 2020-07-13 10:08:43
download_url_created: NULL
        download_url: NULL
4 rows in set (0.00 sec)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1852

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[yadvr]

LGTM based on http://download.cloudstack.org/systemvm/4.14/md5sum.txt

cf58913fb5cc830749760895dc9f406f  systemvmtemplate-4.14.0-hyperv.vhd.zip
4978e6e6140d167556f201496549a498  systemvmtemplate-4.14.0-kvm.qcow2.bz2
3b8df36a9dc8b87ae3892da61d8e2679  systemvmtemplate-4.14.0-ovm.raw.bz2
33cad72f858aef11c95df486b0f21938  systemvmtemplate-4.14.0-vmware.ova
2e3078de2ccce760d537e06fd9b4c7c7  systemvmtemplate-4.14.0-xen.vhd.bz2

[yadvr]

@Pearl1594 4.14.0.0 is already released, can you check for 4.15.0.0 upgrade path against http://download.cloudstack.org/systemvm/4.15/md5sum.txt on master branch?

[Pearl1594]

@rhtyd The 4.15 upgrade path seems to have the right checksums

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1913

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-1920

[yadvr]

Explicit test is not required as it's only changing checksums manually verified against the download.cloudstack.org link