systemvm: Update novnc by davidjumani · Pull Request #4323 · apache/cloudstack

davidjumani · 2020-09-12T11:26:05Z

Description

Updating noVNC v1.2.0

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

FullScreen mode

Paste into console

Additional keys

davidjumani · 2020-09-12T11:27:30Z

@blueorangutan package

blueorangutan · 2020-09-12T11:29:01Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-12T12:23:22Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1972

blueorangutan · 2020-09-12T12:55:04Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1973

blueorangutan · 2020-09-12T15:15:23Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1974

yadvr · 2020-09-12T15:26:19Z

@blueorangutan package

blueorangutan · 2020-09-12T15:26:52Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-12T15:33:07Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1975

blueorangutan · 2020-09-12T16:52:33Z

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-1976

yadvr · 2020-09-12T17:10:10Z

third time's a charm
@blueorangutan package

blueorangutan · 2020-09-12T17:11:08Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-12T18:00:51Z

Packaging result: ✖centos7 ✔centos8 ✔debian. JID-1979

davidjumani · 2020-09-14T06:55:13Z

@blueorangutan package

blueorangutan · 2020-09-14T06:56:15Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

davidjumani · 2020-09-14T11:29:40Z

@blueorangutan package

blueorangutan · 2020-09-14T11:30:13Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-14T12:09:59Z

Packaging result: ✖centos7 ✖centos8 ✔debian. JID-1995

shwstppr · 2020-09-15T04:04:18Z

@blueorangutan package

blueorangutan · 2020-09-15T04:05:22Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-15T04:45:03Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2002

shwstppr · 2020-09-18T02:58:49Z

@rhtyd there are couple of more issues (Chrome incognito, clipboard characters). Already discussed with @davidjumani

davidjumani · 2020-09-18T18:09:14Z

@blueorangutan package

blueorangutan · 2020-09-18T18:10:32Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-18T18:42:10Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2047

yadvr · 2020-09-20T17:05:06Z

@blueorangutan test

blueorangutan · 2020-09-20T17:06:34Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-09-21T06:24:47Z

Trillian test result (tid-2799)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44605 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4323-t2799-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	`Error`	0.04	test_pvlan.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	366.45	test_vpc_redundant.py

shwstppr

LGTM. Tested with KVM env. UI issues mentioned earlier are fixed. Console working fine on incognito mode for different browsers (was seeing some regression earlier). Clipboard functionality working okay.

yadvr · 2020-09-21T08:44:24Z

@blueorangutan package

blueorangutan · 2020-09-21T08:45:05Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-21T09:17:05Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2055

yadvr · 2020-09-21T10:05:37Z

Manually testing and verifying against VMware env

davidjumani · 2020-09-22T04:05:21Z

@blueorangutan package

blueorangutan · 2020-09-22T04:06:09Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-22T05:07:34Z

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2059

yadvr · 2020-09-22T12:10:53Z

Tested against VMware, LGTM
Screenshot looks like this:

Button/clipboard options work as expected:

yadvr

LGTM, noVNC dependency upgrades and button toolbar

Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize

weizhouapache · 2021-03-05T08:49:32Z

-        }
-        UI.updateFullscreenButton();
+        this.fullScreen = !this.fullScreen
+        UI.rfb.scaleViewport = this.fullScreen


@davidjumani
one of our customers has issue accessing the novnc console, because scaleViewport is undefined in line 1216
UI.rfb.scaleViewport = this.fullScreen
But I cannot find this change in novnc repository.
https://github.com/novnc/noVNC/blob/master/app/ui.js#L1209

@weizhouapache I've changed a bit of the novnc UI to allow fullscreen and pasting into the console.
fullscreen is defined at line 44 and scaleViewport is defined in rfb.js

@weizhouapache I've changed a bit of the novnc UI to allow fullscreen and pasting into the console.
fullscreen is defined at line 44 and scaleViewport is defined in rfb.js

@davidjumani
we do not have any problem in our testing. but that customer cannot access the console. he tried with different browsers.
it is strange. it seem UI.rfb is not initialized.

@weizhouapache That could be a bigger issue since rfb.js is used to communicate with the host. Did destroying and recreating the console proxy help ? Also could you check whether the customer has tweaked the novnc code in the cpvm ? Or any issue with the systemvm.iso itself ?

@weizhouapache That could be a bigger issue since rfb.js is used to communicate with the host. Did destroying and recreating the console proxy help ? Also could you check whether the customer has tweaked the novnc code in the cpvm ? Or any issue with the systemvm.iso itself ?

@davidjumani ignore the issue above. It happened when we enlarge the screen when websocket connection is not working. it is a bug but not critical. we are still looking for the root cause of the issue. customer uses German keyboard which is different from us.

@weizhouapache Fixed in #4783
It prevents the fullscreen button from being shown when not connected to the VM

Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize

davidjumani force-pushed the update-novnc branch from 466e7a1 to 6280572 Compare September 12, 2020 11:27

davidjumani mentioned this pull request Sep 12, 2020

Adding button to toggle fullscreen in noVNC console #4313

Closed

5 tasks

Updating novnc

2962e1f

davidjumani force-pushed the update-novnc branch from 6280572 to cbced66 Compare September 12, 2020 17:42

davidjumani force-pushed the update-novnc branch 5 times, most recently from d59c8a0 to 4c8b360 Compare September 13, 2020 11:40

davidjumani marked this pull request as ready for review September 14, 2020 08:46

davidjumani force-pushed the update-novnc branch 3 times, most recently from 2bc0e64 to 5d6f120 Compare September 18, 2020 09:49

shwstppr approved these changes Sep 21, 2020

View reviewed changes

yadvr added this to the 4.15.0.0 milestone Sep 21, 2020

Tweaking novnc to work

b74579e

davidjumani force-pushed the update-novnc branch from 5d6f120 to b74579e Compare September 22, 2020 04:02

yadvr approved these changes Sep 22, 2020

View reviewed changes

yadvr merged commit c06e7de into apache:master Sep 22, 2020

DaanHoogland added the type:enhancement label Oct 21, 2020

davidjumani deleted the update-novnc branch October 27, 2020 14:47

soreana pushed a commit to soreana/cloudstack that referenced this pull request Nov 3, 2020

systemvm: update novnc v1.2.0 (apache#4323)

b74199a

Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize

weizhouapache reviewed Mar 5, 2021

View reviewed changes

DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022

systemvm: update novnc v1.2.0 (apache#4323)

3fe82da

Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize

shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2023

systemvm: update novnc v1.2.0 (apache#4323)

75c972f

Update noVNC v1.2.0, add support for clipboard, explicit button toolbar and resize screensize

Conversation

davidjumani commented Sep 12, 2020 • edited by yadvr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

FullScreen mode

Paste into console

Additional keys

Uh oh!

davidjumani commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

yadvr commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

yadvr commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

blueorangutan commented Sep 12, 2020

Uh oh!

davidjumani commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

davidjumani commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

blueorangutan commented Sep 14, 2020

Uh oh!

shwstppr commented Sep 15, 2020

Uh oh!

blueorangutan commented Sep 15, 2020

Uh oh!

blueorangutan commented Sep 15, 2020

Uh oh!

shwstppr commented Sep 18, 2020

Uh oh!

davidjumani commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

yadvr commented Sep 20, 2020

Uh oh!

blueorangutan commented Sep 20, 2020

Uh oh!

blueorangutan commented Sep 21, 2020

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

blueorangutan commented Sep 21, 2020

Uh oh!

blueorangutan commented Sep 21, 2020

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

davidjumani commented Sep 22, 2020

Uh oh!

blueorangutan commented Sep 22, 2020

Uh oh!

blueorangutan commented Sep 22, 2020

davidjumani commented Sep 12, 2020 •

edited by yadvr

Loading