Skip to content

agent: Compare indirect agent lb algorithm when cloudstack agent conn…#4335

Merged
yadvr merged 1 commit into
apache:4.14from
ustcweizhou:4.14-agent-lb-algorithm
Sep 23, 2020
Merged

agent: Compare indirect agent lb algorithm when cloudstack agent conn…#4335
yadvr merged 1 commit into
apache:4.14from
ustcweizhou:4.14-agent-lb-algorithm

Conversation

@ustcweizhou
Copy link
Copy Markdown
Contributor

Description

Compare not only the list of management servers but also the lb algorithm when agent connects.

Fixes: #3895

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 22, 2020

@Spaceman1984 the fix is in, can you test this PR?
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2060

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 22, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@Spaceman1984
Copy link
Copy Markdown
Contributor

@Spaceman1984 the fix is in, can you test this PR?
@blueorangutan package

On it

@blueorangutan
Copy link
Copy Markdown

@Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2064

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 22, 2020

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-2827)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49589 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4335-t2827-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr modified the milestones: 4.15.0.0, 4.14.1.0 Sep 23, 2020
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 23, 2020

Tests LGTM, will merge once @Spaceman1984 can confirm manual testing

@Spaceman1984
Copy link
Copy Markdown
Contributor

Tested, LGTM

@yadvr yadvr merged commit 534dd47 into apache:4.14 Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants