Skip to content

Remove cpu core from op_host_capacity when host is deleted #4367

Merged
DaanHoogland merged 1 commit into
apache:4.14from
ravening:cpu_core_details
Oct 28, 2020
Merged

Remove cpu core from op_host_capacity when host is deleted #4367
DaanHoogland merged 1 commit into
apache:4.14from
ravening:cpu_core_details

Conversation

@ravening
Copy link
Copy Markdown
Member

@ravening ravening commented Oct 1, 2020

Description

When a host is put into maintenance mode or its deleted from
cloud stack then delete its entries from the op_host_capacity table

Currently, only memory and CPU information is deleted from the table.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Delete a host or put a host into maintenance mode.
All the entries related to this host in op_host_capacity should be deleted

GabrielBrascher
GabrielBrascher approved these changes Oct 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based o code review.
I did not test it, though.

@yadvr yadvr added this to the 4.15.0.0 milestone Oct 1, 2020
@yadvr yadvr requested a review from weizhouapache October 1, 2020 08:27
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 1, 2020

@ravening this is a bug fix, which should be merged into 4.14 as well

@weizhouapache weizhouapache reopened this Oct 1, 2020
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 5, 2020

@ravening will you backport?

@ravening
Copy link
Copy Markdown
Member Author

ravening commented Oct 5, 2020

@ravening will you backport?

I will rebase with 4.14

@DaanHoogland DaanHoogland modified the milestones: 4.15.0.0, 4.14.1.0 Oct 6, 2020
@ravening ravening changed the base branch from master to 4.14 October 12, 2020 08:22
@ravening ravening changed the base branch from 4.14 to master October 12, 2020 08:24
@ravening ravening changed the base branch from master to 4.14 October 12, 2020 08:25
@ravening ravening changed the base branch from 4.14 to master October 12, 2020 08:28
@ravening
Remove cpu core from op_host_capacity while delete a host or put host…
bf16e4c 
… to maintenance

When a host is put into maintenance mode or its deleted from
cloudstack then delete its entries from op_host_capacity table
@ravening ravening changed the base branch from master to 4.14 October 12, 2020 08:35
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Oct 14, 2020

@blueoragutan package

2 similar comments
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 15, 2020

@blueoragutan package

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 20, 2020

@blueoragutan package

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Oct 22, 2020

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 22, 2020

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 22, 2020

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2259

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 27, 2020

@blueorangutan test centos7 kvm-centos7 keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 27, 2020

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 28, 2020

Trillian test result (tid-3082)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33552 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4367-t3082-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_upgrade_kubernetes_cluster Failure 293.62 test_kubernetes_clusters.py

@DaanHoogland DaanHoogland merged commit b9f15fd into apache:4.14 Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@GabrielBrascher GabrielBrascher GabrielBrascher approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

Severity:Minor type:bug

Projects

None yet

Milestone

4.14.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@ravening @weizhouapache @DaanHoogland @yadvr @shwstppr @blueorangutan @GabrielBrascher