Skip to content

systemvm: FIX haproxy is not reloaded but restarted in VR #4384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ustcweizhou wants to merge 1 commit into from
Closed

systemvm: FIX haproxy is not reloaded but restarted in VR #4384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion systemvm/debian/opt/cloud/bin/cs/CsLoadBalancer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def process(self):
CsHelper.copy(HAPROXY_CONF_T, HAPROXY_CONF_P)

proc = CsProcess(['/run/haproxy.pid'])
if not proc.find():
if proc.grep("/usr/sbin/haproxy") == -1:
Copy link
Copy Markdown
Member

@yadvr yadvr Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested this, should this be !=0 instead @ustcweizhou ?

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Oct 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ustcweizhou this is the same fix done in the PR: #4386, changes in "CsRedundant.py" for keepalived process. As I've commented in that PR, on a broader view, other processes might have similar issue. can this be fixed in CsProcess.py ? else slowly at some point, we'll end up replacing all proc.find() with proc.grep().

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache Oct 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti I will make change on proc.find

logging.debug("CsLoadBalancer:: will restart HAproxy!")
CsHelper.service("haproxy", "restart")
else:
Expand Down