Skip to content

systemvm: fix keepalived is always restarted when update config for monitor service #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ustcweizhou wants to merge 1 commit into from
Closed

systemvm: fix keepalived is always restarted when update config for monitor service #4386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion systemvm/debian/opt/cloud/bin/cs/CsRedundant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def _redundant_on(self):
heartbeat_cron.commit()

proc = CsProcess(['/usr/sbin/keepalived'])
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ustcweizhou specifying "/usr/sbin/keepalived" here may not be required as grep is used instead.

I understand this issue is with keepalived process, but on a broader view, other processes might have similar issue later, can this be fixed in CsProcess.py find() ?

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sureshanaparti yes, of course.
To be sure that is not regression issue, I choosed a easier way to fix it.

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti Oct 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @weizhouapache , got it. Note that, if the same issue repeats for other processes later, then CsProcess.py have to be fixed.

if not proc.find():
if proc.grep("/usr/sbin/keepalived") == -1:
force_keepalived_restart = True
if keepalived_conf.is_changed() or force_keepalived_restart:
keepalived_conf.commit()
Expand Down