Skip to content

ui: Show vm name in info card in deployvm#4786

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-deployvm-infocard
Mar 11, 2021
Merged

ui: Show vm name in info card in deployvm#4786
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-deployvm-infocard

Conversation

@davidjumani
Copy link
Copy Markdown
Contributor

@davidjumani davidjumani commented Mar 10, 2021

Description

This PR shows the name of the VM in the info card next to the avatar rather than in the title

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

Before :

Screenshot from 2021-03-10 14-54-11

After :

Screenshot from 2021-03-10 14-50-43

@davidjumani
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4786 (JID-3860)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@utchoang
Copy link
Copy Markdown

@davidjumani can you change the base branch of the PR and rebase your PR branch to 4.15?

@davidjumani davidjumani force-pushed the fix-deployvm-infocard branch from f745c52 to 3dbcc0a Compare March 11, 2021 00:53
@davidjumani davidjumani changed the base branch from master to 4.15 March 11, 2021 00:53
@davidjumani
Copy link
Copy Markdown
Contributor Author

@utchoang Done!

@yadvr yadvr added this to the 4.15.1.0 milestone Mar 11, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 11, 2021

LGTM

@yadvr yadvr merged commit 8510344 into apache:4.15 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants