Skip to content

ui: Fix breadcrumb discrepancy#4788

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-breadcrumb
Mar 11, 2021
Merged

ui: Fix breadcrumb discrepancy#4788
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-breadcrumb

Conversation

@davidjumani
Copy link
Copy Markdown
Contributor

@davidjumani davidjumani commented Mar 10, 2021 •
edited
Loading

Description

This PR aligns the breadcrumb with the info card display name

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before :

Screenshot from 2021-03-10 15-00-19

After :

Screenshot from 2021-03-10 15-00-46

@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Mar 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 10, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4788 (JID-3862)

@utchoang
Copy link
Copy Markdown

utchoang commented Mar 11, 2021

@davidjumani can you change the base branch of the PR and rebase your PR branch to 4.15?

@davidjumani davidjumani changed the base branch from master to 4.15 March 11, 2021 00:56
@davidjumani
Copy link
Copy Markdown
Contributor Author

davidjumani commented Mar 11, 2021

@utchoang Done!
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 11, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 11, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4788 (SL-JID-19)

utchoang
utchoang approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr added this to the 4.15.1.0 milestone Mar 11, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Mar 11, 2021

LGTM

@yadvr yadvr merged commit 314baec into apache:4.15 Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utchoang utchoang utchoang approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@davidjumani @blueorangutan @utchoang @yadvr