Skip to content

ui - Project Role Permission: Change default permission type to 'Deny'#4832

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:proj-role-perm-default
Mar 17, 2021
Merged

ui - Project Role Permission: Change default permission type to 'Deny'#4832
yadvr merged 1 commit intoapache:4.15from
shapeblue:proj-role-perm-default

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR changes the default project role permission type to 'deny' as project role permissions are basically restrictive in nature, i.e., they are used to deny users/accounts in a project from performing certain actions that they would be allowed at the account-level, hence making sense to have the default permission to be Deny.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

As shown in the screenshot above, the default permission is Deny while adding project role permissions

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@Pearl1594 Pearl1594 changed the title Project Role Permission: Change default permission type to 'Deny' ui - Project Role Permission: Change default permission type to 'Deny' Mar 17, 2021
@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4832 (SL-JID-34)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.15.1.0 milestone Mar 17, 2021
@yadvr yadvr merged commit d81141e into apache:4.15 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants