novnc: Fix vm console is not working on firefox if language is not English#4833
Merged
yadvr merged 1 commit intoapache:4.15from Mar 17, 2021
Merged
Conversation
Contributor
Author
|
@davidjumani please review and test it |
Contributor
|
@blueorangutan package |
|
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S] |
davidjumani
approved these changes
Mar 17, 2021
Contributor
davidjumani
left a comment
davidjumani
left a comment
There was a problem hiding this comment.
LGTM! Tested and Working
Member
|
Merging based on Travis job1 as manually it was tested by David (novnc console is not covered otherwise by marvin tests). |
|
Packaging result: ✖️ centos7 ✔️ centos8 ✔️ debian. SL-JID 149 |
|
We have hit the same issue. Shall we have it in 4.15.1 as well since it's not released yet. |
Member
@luhaijiao it has been merged into 4.15 branch, it will be released in 4.15.1.0 |
DaanHoogland
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
May 20, 2022
shwstppr
pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the blank screen issue of novnc console if language is not English in some browsers.
Steps to reproduce the issue
(1) install firefox, and switch to another language other than English, for example Germany, Russian.
refer to https://support.mozilla.org/en-US/kb/use-firefox-another-language
(2) open vm console
Expected result: console works
Actual result: the first time it works, then blank screen in retries (also with other vms).
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?