Skip to content

Added info / tooltip for add role and import role dialogs in the UI#4836

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:cs-ui-add-and-import-role-tooltip-info
Mar 18, 2021
Merged

Added info / tooltip for add role and import role dialogs in the UI#4836
yadvr merged 1 commit intoapache:4.15from
shapeblue:cs-ui-add-and-import-role-tooltip-info

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

Description

This PR added info / tooltip for add role and import role dialogs in the UI.

Fixes: #4835

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Add Role Dialog =>

Before Changes:

AddRole

After Changes:

AddRoleWithInfo

Import Role Dialog =>

Before Changes:

ImportRole

After Changes:

ImportRoleWithInfo

How Has This Been Tested?

Manually tested the Add Role and Import Role from UI

@sureshanaparti sureshanaparti force-pushed the cs-ui-add-and-import-role-tooltip-info branch from 4703cfb to 16992a1 Compare March 17, 2021 14:02
@Pearl1594
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4836 (SL-JID-35)

Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on code review and manual test.

Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@shwstppr shwstppr added this to the 4.15.1.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants