ui: Fix route to ISO From VM's Info Card / Detail View#4839
Merged
yadvr merged 2 commits intoapache:4.15from Mar 18, 2021
Merged
ui: Fix route to ISO From VM's Info Card / Detail View#4839yadvr merged 2 commits intoapache:4.15from
yadvr merged 2 commits intoapache:4.15from
Conversation
Contributor
Author
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S] |
|
UI build: ✔️ |
shwstppr
approved these changes
Mar 18, 2021
shwstppr
reviewed
Mar 18, 2021
| @@ -398,7 +398,12 @@ | |||
| <div class="resource-detail-item__label">{{ $t('label.templatename') }}</div> | |||
Contributor
There was a problem hiding this comment.
@Pearl1594 should we also have label read ISO with something like
Suggested change
| <div class="resource-detail-item__label">{{ $t('label.templatename') }}</div> | |
| <div class="resource-detail-item__label">{{ resource.isoid ? $t('label.iso') : $t('label.templatename') }}</div> |
Contributor
Author
There was a problem hiding this comment.
Thanks @shwstppr. Makes sense.. I've updated the PR.
Contributor
Author
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S] |
|
UI build: ✔️ |
shwstppr
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the route to Iso tab from the respective VM's detail View (Info card) if the VM is deployed from an ISO.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Deploy VM from an ISO and traverse to the ISO tab from the detail view
Before Fix:
Post Fix:
Successfully able to route to iso tab