ui: Display root disk size in Compute offering details#4862
Merged
yadvr merged 1 commit intoapache:4.15from Apr 1, 2021
Merged
ui: Display root disk size in Compute offering details#4862yadvr merged 1 commit intoapache:4.15from
yadvr merged 1 commit intoapache:4.15from
Conversation
Contributor
Author
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
| </div> | ||
| <div v-else-if="$route.meta.name === 'computeoffering' && item === 'rootdisksize'"> | ||
| <div> | ||
| {{ parseFloat( resource.rootdisksize / (1024.0 * 1024.0 * 1024.0)).toFixed(1) }} GB |
Contributor
There was a problem hiding this comment.
Suggestion:
I think it would be nice to us to have an utility that centralizes and assures that we always do the same calculation.
@Pearl1594 do you think it would be possible to create an utility to centralize these byte convertions? Like a getGib(value = 1) which return value * 1024 * 1024 * 1024 or value * GiB (GiB would be a constant = 1024 * 1024 * 1024).
Contributor
Author
There was a problem hiding this comment.
Makes sense.. I can do that. Thanks @GutoVeronezi
utchoang
approved these changes
Mar 31, 2021
yadvr
approved these changes
Apr 1, 2021
yadvr
approved these changes
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR displays the Root disk size as part of compute offering details if the offering was created with it specified.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
Prior to this fix: When a compute offering is created with root disk size specified, there is not indication of this attribute in the corresponding Compute offering's details.
Post fix:
