systemvm: remove logrotate config for wtmp and btmp by ustcweizhou · Pull Request #4872 · apache/cloudstack

ustcweizhou · 2021-03-25T09:57:32Z

Description

logrotate in systemvms run every day. however it exits with failure.

root@r-100-VM:~# systemctl status logrotate
● logrotate.service - Rotate log files
   Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled)
   Active: failed (Result: exit-code) since Thu 2021-03-23 00:00:01 UTC; 2 days ago
     Docs: man:logrotate(8)
           man:logrotate.conf(5)
  Process: 25001 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=1/FAILURE)
 Main PID: 25001 (code=exited, status=1/FAILURE)

Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable.

it is because the logrotate for wtmp and btmp already exist in 4.15 systemvm template.

root@r-100-VM:~# cat /etc/logrotate.d/wtmp
/var/log/wtmp {
    missingok
    monthly
    create 0664 root utmp
    minsize 1M
    rotate 1
}
root@r-100-VM:~# cat /etc/logrotate.d/btmp
/var/log/btmp {
    missingok
    monthly
    create 0660 root utmp
    rotate 1
}

remove them from /etc/logrotate.conf fixes the issue.

root@r-100-VM:~# systemctl status logrotate
● logrotate.service - Rotate log files
   Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled)
   Active: inactive (dead) since Thu 2021-03-25 00:00:01 UTC; 9h ago
     Docs: man:logrotate(8)
           man:logrotate.conf(5)
  Process: 28211 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=0/SUCCESS)
 Main PID: 28211 (code=exited, status=0/SUCCESS)

Mar 25 00:00:01 r-100-VM systemd[1]: Starting Rotate log files...
Mar 25 00:00:01 r-100-VM systemd[1]: logrotate.service: Succeeded.
Mar 25 00:00:01 r-100-VM systemd[1]: Started Rotate log files.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

logrotate in systemvms run every day. it exits with failure. ``` root@r-100-VM:~# systemctl status logrotate ● logrotate.service - Rotate log files Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled) Active: failed (Result: exit-code) since Thu 2021-03-23 00:00:01 UTC; 2 days ago Docs: man:logrotate(8) man:logrotate.conf(5) Process: 25001 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=1/FAILURE) Main PID: 25001 (code=exited, status=1/FAILURE) Warning: Journal has been rotated since unit was started. Log output is incomplete or unavailable. ``` it is because the logrotate for wtmp and btmp already exist in 4.15 systemvm template. ``` root@r-100-VM:~# cat /etc/logrotate.d/wtmp /var/log/wtmp { missingok monthly create 0664 root utmp minsize 1M rotate 1 } root@r-100-VM:~# cat /etc/logrotate.d/btmp /var/log/btmp { missingok monthly create 0660 root utmp rotate 1 } ``` remove them from /etc/logrotate.conf fixes the issue. ``` root@r-100-VM:~# systemctl status logrotate ● logrotate.service - Rotate log files Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset: enabled) Active: inactive (dead) since Thu 2021-03-25 00:00:01 UTC; 9h ago Docs: man:logrotate(8) man:logrotate.conf(5) Process: 28211 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=0/SUCCESS) Main PID: 28211 (code=exited, status=0/SUCCESS) Mar 25 00:00:01 r-100-VM systemd[1]: Starting Rotate log files... Mar 25 00:00:01 r-100-VM systemd[1]: logrotate.service: Succeeded. Mar 25 00:00:01 r-100-VM systemd[1]: Started Rotate log files. ```

yadvr · 2021-03-29T11:10:42Z

@blueorangutan package

blueorangutan · 2021-03-29T11:11:13Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-29T12:10:10Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 281

yadvr · 2021-03-29T12:33:15Z

@blueorangutan test

blueorangutan · 2021-03-29T12:34:04Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T13:37:00Z

Trillian Build Failed (tid-286)

yadvr · 2021-03-29T13:44:41Z

@blueorangutan test

blueorangutan · 2021-03-29T13:45:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-29T14:37:18Z

Trillian Build Failed (tid-295)

GabrielBrascher

LGTM (I did not test it)

Pearl1594 · 2021-03-30T05:11:03Z

@blueorangutan test

blueorangutan · 2021-03-30T05:12:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-30T15:58:12Z

Trillian test result (tid-301)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36996 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4872-t301-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAntiAffinityGroup_in_project	`Error`	59.96	test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup	`Error`	35.33	test_affinity_groups.py
test_04_deploy_and_scale_kubernetes_cluster	`Failure`	25.58	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.04	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	35.18	test_kubernetes_clusters.py
test_01_isolate_network_FW_PF_default_routes_egress_true	`Failure`	269.43	test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false	`Failure`	269.01	test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Failure`	310.05	test_routers_network_ops.py
test_hostha_kvm_host_degraded	`Failure`	701.78	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Failure`	641.91	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	4.38	test_hostha_kvm.py

Pearl1594 · 2021-03-31T04:31:25Z

test failures noticed are due to a setup issue as there was only one host added - resulting in capacity issues. Re-running tests

Pearl1594 · 2021-03-31T04:31:34Z

@blueorangutan test

blueorangutan · 2021-03-31T04:32:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2021-03-31T05:26:52Z

Trillian Build Failed (tid-304)

yadvr · 2021-04-01T06:57:51Z

@blueorangutan test

blueorangutan · 2021-04-01T06:59:04Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2021-04-01T07:21:13Z

Nevermind, last test run LGTM - none of the failures related to logrotate config change.

blueorangutan · 2021-04-01T17:53:52Z

Trillian test result (tid-325)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36882 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4872-t325-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	78.25	test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume	`Error`	67.13	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	50.05	test_vm_life_cycle.py

ustcweizhou force-pushed the 4.15-fix-logrotate-systemvm branch from df59a53 to aec932d Compare March 25, 2021 09:58

DaanHoogland approved these changes Mar 29, 2021

View reviewed changes

yadvr added this to the 4.15.1.0 milestone Mar 29, 2021

yadvr approved these changes Mar 29, 2021

View reviewed changes

GabrielBrascher approved these changes Mar 29, 2021

View reviewed changes

yadvr merged commit dc5b9ec into apache:4.15 Apr 1, 2021

weizhouapache mentioned this pull request Aug 17, 2021

Files in /var/cache/cloud/processed on virtual router are not cleaned up #3757

Closed

Conversation

ustcweizhou commented Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

yadvr commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

yadvr commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

yadvr commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

blueorangutan commented Mar 29, 2021

Uh oh!

GabrielBrascher left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 commented Mar 30, 2021

Uh oh!

blueorangutan commented Mar 30, 2021

Uh oh!

blueorangutan commented Mar 30, 2021

Uh oh!

Pearl1594 commented Mar 31, 2021

Uh oh!

Pearl1594 commented Mar 31, 2021

Uh oh!

blueorangutan commented Mar 31, 2021

Uh oh!

blueorangutan commented Mar 31, 2021

Uh oh!

yadvr commented Apr 1, 2021

Uh oh!

blueorangutan commented Apr 1, 2021

Uh oh!

yadvr commented Apr 1, 2021

Uh oh!

blueorangutan commented Apr 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ustcweizhou commented Mar 25, 2021 •

edited

Loading