usage backup: Raw usage/usage display to record time duration of usage#5005
usage backup: Raw usage/usage display to record time duration of usage#5005Pearl1594 wants to merge 1 commit into
Conversation
|
@blueorangutan package |
|
@blueorangutan package |
|
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✖️ centos8 ✖️ debian. SL-JID 554 |
| final Long vmId = backupInfo.getVmId(); | ||
| final Long zoneId = backupInfo.getZoneId(); | ||
| final Long offeringId = backupInfo.getOfferingId(); | ||
| float usage = runningTime / 1000f / 60f / 60f; |
There was a problem hiding this comment.
@Pearl1594 as this calculation is done several times in the code, we could create an utility to it.
|
@Pearl1594 does this pr fix #4982 ? is it ready for review ? |
|
Hi @Pearl1594, @weizhouapache has created PR #5259 to fix #4982, can you please sync to work on a unified solution? |
|
Will do @nvazquez @weizhouapache - Thanks. |
|
Hi @Pearl1594 any update on this? Can both PRs be integrated into a single one to fix the issue #4982? |
|
Hi @nvazquez - was held up in other tasks, hence wasn't able to test #5259. However, on doing a code review, I believe, both PRs solve the same issue, and @weizhouapache's solution would be less disruptive and more apt to address the issue - so maybe we could go ahead with #5259. I'll spend some time testing it as well. Apologies for the delay. |
|
@Pearl1594 tentatively moving to 4.15.2.0 milestone - please advise if it's feasible/ready for 4.15? |
|
Since PR #5259 addresses the same issue - I'll close this PR |
7 participants
Description
This PR ensure consistency between usage details stored across different resource types. For the sake of consistency, backup usage record will show the time duration of backup usage in the raw_usage / usage_display fields.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?