ui: Go back for delete actions before querying async job#5360
Conversation
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
| break | ||
| } | ||
| } | ||
| if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) { |
There was a problem hiding this comment.
Could this cause regression that you go back to previous screen and the action fails for some reason?
| } | ||
| } | ||
| if ((action.icon === 'delete' || ['archiveEvents', 'archiveAlerts', 'unmanageVirtualMachine'].includes(action.api)) && this.dataView) { | ||
| this.$router.go(-1) |
There was a problem hiding this comment.
@davidjumani is it possible to check if previous page even exist? Like I can login with a VM details page redirect and then delete that VM. In that case will this take me back to VM list?
There was a problem hiding this comment.
Will redirect to the dashboard. Right now vue doesn't support getting the history list so instead we need to use hooks for every navigation (to ensure we go up instead of to the dashboard) which will slow down the UI
|
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
shwstppr
left a comment
shwstppr
left a comment
There was a problem hiding this comment.
LGTM. Tested deleting and deploying resource, works fine.
7 participants
Description
Fixes #5352
Navigates back in history before querying the result of an async job for any delete action
Querying the result leads to a page refresh which can cause an error if it is a delete action and the page has not been changed
Types of changes
Bug Severity