UI - Add clear all notification button by utchoang · Pull Request #5549 · apache/cloudstack

utchoang · 2021-10-05T02:11:38Z

Description

Fixes #5538

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

utchoang · 2021-10-05T02:20:19Z

@blueorangutan ui

blueorangutan · 2021-10-05T02:21:04Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-10-05T02:25:28Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-728)

davidjumani · 2021-10-05T04:56:38Z

@utchoang The notifications cover the usermenu and the clear all icon

utchoang · 2021-10-05T05:45:08Z

@davidjumani Please refresh or clear cache, I have the same problem as you in QA server but after ctrl+f5 it works fine.

utchoang · 2021-10-05T05:49:53Z

@blueorangutan ui

blueorangutan · 2021-10-05T05:51:03Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-10-05T05:56:43Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-732)

davidjumani · 2021-10-05T07:19:03Z

@blueorangutan ui

davidjumani · 2021-10-05T07:32:46Z

@blueorangutan ui

blueorangutan · 2021-10-05T07:33:03Z

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-10-05T07:38:18Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-733)

yadvr · 2021-10-05T07:52:03Z

The UX is weird, it won't be obvious for first-time users what the new icons does. Should there be a floating widget on the top saying clear all? (something like that seen in phones?)

utchoang · 2021-10-05T08:41:27Z

@rhtyd cc @davidjumani I also noticed this inconvenience. But still can't find a better solution. What do you think?

utchoang · 2021-10-05T09:01:13Z

Close because it doesn't solve the problem because the notifications will automatically turn off after duration 5s. Will consider putting clear all button at the top of notifications

DaanHoogland · 2021-10-05T09:01:30Z

@utchoang @rhtyd I think at least the clear notifications button should be next to the view notifications button

utchoang · 2021-10-05T09:18:27Z

Another solution for the clear notification button. What do you think about this?
cc @rhtyd @DaanHoogland @davidjumani

utchoang · 2021-10-06T01:24:51Z

@blueorangutan ui

blueorangutan · 2021-10-06T01:31:44Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-734)

davidjumani · 2021-10-06T04:01:23Z

@utchoang Would it be possible to add a clear all button on just the first notification ?

DaanHoogland · 2021-10-06T09:09:20Z

How about an item in the notifications menu, near 'clear list', @utchoang ?

utchoang · 2021-10-06T09:48:58Z

@DaanHoogland I don't think that's reasonable. What do you think about the position of clear button as below image?

utchoang · 2021-10-06T12:46:11Z

@blueorangutan ui

blueorangutan · 2021-10-06T12:47:03Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-10-06T12:51:26Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-737)

DaanHoogland · 2021-10-07T06:29:33Z

@DaanHoogland I don't think that's reasonable. What do you think about the position of clear button as below image?
I like my idea better ;)
/me not making a fuzz about it.

yadvr · 2021-11-18T08:29:14Z

@blueorangutan ui

blueorangutan · 2021-11-18T08:30:06Z

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-11-18T11:21:38Z

UI build: ✖️
(SL-JID-841)

sureshanaparti · 2021-12-16T13:33:27Z

@blueorangutan ui

blueorangutan · 2021-12-16T13:34:03Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-12-16T13:51:31Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-909)

shwstppr

Works as expected. Though I don't like the idea of clear button in the first notification. A separate button at the top of the notifications would have made more sense, as shown earlier by @utchoang,

utchoang · 2021-12-29T06:39:19Z

@shwstppr I reverted the clear all button back to the top of the notification. You can check and we can merge.

utchoang · 2021-12-29T06:39:37Z

@blueorangutan ui

blueorangutan · 2021-12-29T06:40:03Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-12-29T06:47:02Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5549 (SL-JID-947)

Related to PR #5549 changed the notification from $notification to $showNotification. This PR aims to change it back to the way it was for easier use while keeping the delete all button.

utchoang added 3 commits October 5, 2021 09:08

add clear all notification button

67deb51

change position set count notify

bdacdd6

get notification count

0183801

apache deleted a comment from blueorangutan Oct 5, 2021

utchoang requested review from davidjumani and shwstppr October 5, 2021 02:19

set label transliteration

f98fe1d

apache deleted a comment from blueorangutan Oct 5, 2021

add margin for notification

e74168c

yadvr added this to the 4.16.1.0 milestone Oct 5, 2021

utchoang closed this Oct 5, 2021

utchoang reopened this Oct 5, 2021

yadvr changed the base branch from main to 4.16 November 15, 2021 10:11

sureshanaparti added the component:UI label Dec 7, 2021

sureshanaparti requested a review from Pearl1594 December 20, 2021 05:49

sureshanaparti added the status:needs-testing label Dec 20, 2021

shwstppr approved these changes Dec 21, 2021

View reviewed changes

utchoang force-pushed the feature/clear-all-notification-button branch from 074d892 to b1131fb Compare December 29, 2021 06:35

yadvr approved these changes Dec 30, 2021

View reviewed changes

yadvr merged commit eb04a46 into apache:4.16 Dec 30, 2021

yadvr mentioned this pull request Dec 30, 2021

UI - notification stacking on error messages #5538

Closed

utchoang mentioned this pull request Dec 31, 2021

UI - Refactoring $notification according to the old version #5819

Merged

12 tasks

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Conversation

utchoang commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

utchoang commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

davidjumani commented Oct 5, 2021

Uh oh!

utchoang commented Oct 5, 2021

Uh oh!

utchoang commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

davidjumani commented Oct 5, 2021

Uh oh!

davidjumani commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

blueorangutan commented Oct 5, 2021

Uh oh!

yadvr commented Oct 5, 2021

Uh oh!

utchoang commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Oct 5, 2021

Uh oh!

utchoang commented Oct 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Oct 6, 2021

Uh oh!

blueorangutan commented Oct 6, 2021

Uh oh!

davidjumani commented Oct 6, 2021

Uh oh!

DaanHoogland commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Oct 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Oct 6, 2021

Uh oh!

blueorangutan commented Oct 6, 2021

Uh oh!

blueorangutan commented Oct 6, 2021

Uh oh!

DaanHoogland commented Oct 7, 2021

Uh oh!

yadvr commented Nov 18, 2021

Uh oh!

blueorangutan commented Nov 18, 2021

Uh oh!

blueorangutan commented Nov 18, 2021

Uh oh!

sureshanaparti commented Dec 16, 2021

Uh oh!

blueorangutan commented Dec 16, 2021

Uh oh!

blueorangutan commented Dec 16, 2021

Uh oh!

utchoang commented Oct 5, 2021 •

edited

Loading

utchoang commented Oct 5, 2021 •

edited

Loading

utchoang commented Oct 5, 2021 •

edited

Loading

utchoang commented Oct 5, 2021 •

edited

Loading

DaanHoogland commented Oct 6, 2021 •

edited

Loading

utchoang commented Oct 6, 2021 •

edited

Loading