Skip to content

CsDhcp.py: fix runtests.sh error#5671

Merged
weizhouapache merged 1 commit into
apache:4.16from
shapeblue:4.16-fix-runtests.sh-with-CsDhcp
Nov 17, 2021
Merged

CsDhcp.py: fix runtests.sh error#5671
weizhouapache merged 1 commit into
apache:4.16from
shapeblue:4.16-fix-runtests.sh-with-CsDhcp

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes the pycodestyle check failures caused by CsDhcp.py

$ cd systemvm/test
$ bash -x runtests.sh
......
../debian/opt/cloud/bin/cs/CsDhcp.py:114:25: E266 too many leading '#' for block comment
+ '[' 1 -gt 0 ']'
+ echo 'pycodestyle failed, please check your code'

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

$ cd systemvm/test
$ bash -x runtests.sh
......
../debian/opt/cloud/bin/cs/CsDhcp.py:114:25: E266 too many leading '#' for block comment
+ '[' 1 -gt 0 ']'
+ echo 'pycodestyle failed, please check your code'
@yadvr yadvr changed the base branch from main to 4.16 November 10, 2021 19:53
@yadvr yadvr added this to the 4.16.1.0 milestone Nov 10, 2021
@weizhouapache weizhouapache merged commit 4568a68 into apache:4.16 Nov 17, 2021
@weizhouapache
Copy link
Copy Markdown
Member Author

simple python change, test is not required.
thanks for review !

@weizhouapache weizhouapache deleted the 4.16-fix-runtests.sh-with-CsDhcp branch December 9, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants