UI - Add Network: shows "Offering for Isolated networks with no Source Nat service" on Network Offering for normal users

[utchoang]

Description

This PR fixes #5897

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5904 (SL-JID-1067)

[weizhouapache]

this depends on #5920 . when #5920 is approved and merged into 4.16/main, I will review this pr.

[DaanHoogland]

this depends on #5920 . when #5920 is approved and merged into 4.16/main, I will review this pr.

it just was @weizhouapache

[sureshanaparti]

this depends on #5920 . when #5920 is approved and merged into 4.16/main, I will review this pr.

it just was @weizhouapache

@DaanHoogland @weizhouapache work in this PR is still in progress. don't review now.

[sureshanaparti]

Hi @utchoang Is this PR ready for review / testing.

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5904 (SL-JID-1107)

[sureshanaparti]

Verified with admin and user accounts, able to view the network offerings without source nat. LGTM.

[weizhouapache]

I have tested it just now.

root admin is able to see network offerings for isolated networks, vpc networks (with specifyvlan=true or false). good.
normal user is able to see network offerings for isolated networks, vpc networks (with specifyvlan=false). good
However...
domain admin can only see network offerings for isolated networks, but not vpc networks.

[sureshanaparti]

@blueorangutan ui

[blueorangutan]

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5904 (SL-JID-1112)

[sureshanaparti]

I have tested it just now.

root admin is able to see network offerings for isolated networks, vpc networks (with specifyvlan=true or false). good. normal user is able to see network offerings for isolated networks, vpc networks (with specifyvlan=false). good However... domain admin can only see network offerings for isolated networks, but not vpc networks.

Hi @weizhouapache can you confirm the domain admin case with the latest changes.

[weizhouapache]

@utchoang @sureshanaparti
I am still not able to see offering for vpc networks when login as domain admin.

see screenshot below

for normal users, it looks ok. see below

[weizhouapache]

after discussion with @sureshanaparti , I checked my environment and found out it is because regular user has 1 vpc but domain admin does not. it makes sense.

[sureshanaparti]

thanks for testing this @weizhouapache