Skip to content

prevent <ctrl>-<enter> handler from <space> from toggling checkboxes#6027

Merged
sureshanaparti merged 5 commits into
apache:4.16from
shapeblue:spaceToggles
Feb 23, 2022
Merged

prevent <ctrl>-<enter> handler from <space> from toggling checkboxes#6027
sureshanaparti merged 5 commits into
apache:4.16from
shapeblue:spaceToggles

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Feb 22, 2022 •
edited
Loading

Description

This PR...

Fixes: #6017

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

manually tested the register template form.

future work

testing each of the changes one by one, as the solution seems too generic

  • fixed: ui/src/components/view/ResourceLimitTab.vue
  • modified: ui/src/views/AutogenView.vue
  • checked: ui/src/views/auth/Login.vue
  • c: ui/src/views/compute/AttachIso.vue
  • modified: ui/src/views/compute/ChangeAffinity.vue
  • modified: ui/src/views/compute/CreateKubernetesCluster.vue
  • modified: ui/src/views/compute/CreateSSHKeyPair.vue
  • modified: ui/src/views/compute/CreateSnapshotWizard.vue
  • modified: ui/src/views/compute/DeployVM.vue
  • modified: ui/src/views/compute/DestroyVM.vue
  • modified: ui/src/views/compute/EditVM.vue
  • modified: ui/src/views/compute/ScaleKubernetesCluster.vue
  • modified: ui/src/views/compute/ScaleVM.vue
  • modified: ui/src/views/compute/StartVirtualMachine.vue
  • modified: ui/src/views/compute/UpgradeKubernetesCluster.vue
  • modified: ui/src/views/compute/backup/FormSchedule.vue
  • f: ui/src/views/iam/AddAccount.vue
  • modified: ui/src/views/iam/AddLdapAccount.vue
  • modified: ui/src/views/iam/AddUser.vue
  • modified: ui/src/views/iam/ChangeUserPassword.vue
  • modified: ui/src/views/iam/ConfigureSamlSsoAuth.vue
  • modified: ui/src/views/iam/CreateRole.vue
  • modified: ui/src/views/iam/DomainActionForm.vue
  • modified: ui/src/views/iam/EditUser.vue
  • modified: ui/src/views/iam/ImportRole.vue
  • modified: ui/src/views/image/AddKubernetesSupportedVersion.vue
  • f: ui/src/views/image/RegisterOrUploadIso.vue
  • f: ui/src/views/image/RegisterOrUploadTemplate.vue
  • modified: ui/src/views/image/UpdateKubernetesSupportedVersion.vue
  • modified: ui/src/views/image/UpdateTemplate.vue
  • modified: ui/src/views/infra/AddPrimaryStorage.vue
  • modified: ui/src/views/infra/AddSecondaryStorage.vue
  • modified: ui/src/views/infra/MigrateData.vue
  • modified: ui/src/views/infra/PodAdd.vue
  • modified: ui/src/views/infra/network/DedicatedVLANTab.vue
  • modified: ui/src/views/infra/network/EditTrafficLabel.vue
  • modified: ui/src/views/infra/network/ServiceProvidersTab.vue
  • modified: ui/src/views/infra/network/providers/AddF5LoadBalancer.vue
  • modified: ui/src/views/infra/network/providers/AddNetscalerLoadBalancer.vue
  • modified: ui/src/views/infra/network/providers/AddNiciraNvpDevice.vue
  • modified: ui/src/views/infra/network/providers/AddPaloAltoFirewall.vue
  • modified: ui/src/views/infra/network/providers/AddSrxFirewall.vue
  • modified: ui/src/views/infra/zone/AdvancedGuestTrafficForm.vue
  • modified: ui/src/views/infra/zone/IpAddressRangeForm.vue
  • modified: ui/src/views/infra/zone/StaticInputsForm.vue
  • modified: ui/src/views/infra/zone/ZoneWizardPhysicalNetworkSetupStep.vue
  • modified: ui/src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
  • modified: ui/src/views/infra/zone/ZoneWizardZoneTypeStep.vue
  • modified: ui/src/views/network/CreateIsolatedNetworkForm.vue
  • modified: ui/src/views/network/CreateL2NetworkForm.vue
  • modified: ui/src/views/network/CreateSharedNetworkForm.vue
  • modified: ui/src/views/network/CreateVlanIpRange.vue
  • modified: ui/src/views/network/CreateVpc.vue
  • modified: ui/src/views/network/CreateVpnCustomerGateway.vue
  • modified: ui/src/views/network/InternalLBAssignVmForm.vue
  • modified: ui/src/views/network/UpdateNetwork.vue
  • modified: ui/src/views/offering/AddComputeOffering.vue
  • modified: ui/src/views/offering/AddDiskOffering.vue
  • modified: ui/src/views/offering/AddNetworkOffering.vue
  • modified: ui/src/views/offering/AddVpcOffering.vue
  • modified: ui/src/views/offering/ImportBackupOffering.vue
  • modified: ui/src/views/offering/UpdateOfferingAccess.vue
  • modified: ui/src/views/plugins/quota/EmailTemplateDetails.vue
  • modified: ui/src/views/project/InvitationTokenTemplate.vue
  • modified: ui/src/views/storage/AttachVolume.vue
  • modified: ui/src/views/storage/CreateSnapshotFromVMSnapshot.vue
  • modified: ui/src/views/storage/CreateVolume.vue
  • modified: ui/src/views/storage/FormSchedule.vue
  • modified: ui/src/views/storage/ResizeVolume.vue
  • modified: ui/src/views/storage/RestoreAttachBackupVolume.vue
  • modified: ui/src/views/storage/TakeSnapshot.vue
  • modified: ui/src/views/storage/UploadLocalVolume.vue

@DaanHoogland DaanHoogland added this to the 4.16.1.0 milestone Feb 22, 2022
@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented Feb 22, 2022

@blueorangutan ui

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Feb 22, 2022

@utchoang can you advice if there is a better generic solution to handling keyboard navigation?

@DaanHoogland DaanHoogland mentioned this pull request Feb 23, 2022
Closed
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Feb 23, 2022

I reverted the generic change and limited to the register template form. I'm sure more of these issues will come up.

sureshanaparti
sureshanaparti reviewed Feb 23, 2022
View reviewed changes
Comment thread ui/src/views/image/RegisterOrUploadTemplate.vue
@DaanHoogland DaanHoogland changed the base branch from main to 4.16 February 23, 2022 10:31
@DaanHoogland DaanHoogland marked this pull request as ready for review February 23, 2022 10:36
Pearl1594
Pearl1594 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
There are a few other forms where we have checkboxes that are effected which include:

  • Create Network Offering
  • Create VPC offering
  • Assign LB rule to VM
    However, we can address these in 4.17 too.

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Feb 23, 2022

LGTM. There are a few other forms where we have checkboxes that are effected which include:

* Create Network Offering

* Create VPC offering

* Assign LB rule to VM
  However, we can address these in 4.17 too.

tnx @pearl, added.

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented Feb 23, 2022

@blueorangutan ui

@apache apache deleted a comment from blueorangutan Feb 23, 2022
@apache apache deleted a comment from blueorangutan Feb 23, 2022
@apache apache deleted a comment from blueorangutan Feb 23, 2022
@apache apache deleted a comment from blueorangutan Feb 23, 2022
@apache apache deleted a comment from blueorangutan Feb 23, 2022
@apache apache deleted a comment from blueorangutan Feb 23, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2022

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Feb 23, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6027 (SL-JID-1182)

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Feb 23, 2022

Manually tested the forms for 'Register template', 'Create Network Offering', 'Create VPC offering' forms. LGTM

nvazquez
nvazquez approved these changes Feb 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sureshanaparti sureshanaparti merged commit 19b8da2 into apache:4.16 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazquez nvazquez nvazquez approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@utchoang utchoang Awaiting requested review from utchoang

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.16.1
Status: Done

Milestone

4.16.1.0

Development

Successfully merging this pull request may close these issues.

UI: space does not select/unselect check boxes

5 participants

@DaanHoogland @Pearl1594 @blueorangutan @sureshanaparti @nvazquez