Skip to content

Display proper gateway length in health check result#6226

Merged
yadvr merged 1 commit intoapache:mainfrom
ravening:gwcheck
Apr 8, 2022
Merged

Display proper gateway length in health check result#6226
yadvr merged 1 commit intoapache:mainfrom
ravening:gwcheck

Conversation

@ravening
Copy link
Copy Markdown
Member

@ravening ravening commented Apr 7, 2022

Description

The output always returns 1 since all gateways are present in one line
but the actual output should be the number of gateways present
in that line

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before the fix

# python gateways_check.py basic
gw is [{u'gatewaysIps': u'10.135.126.254 169.254.0.1'}]
gwsList is [u'10.135.126.254', u'169.254.0.1']
All 1 gateways are reachable via ping

After the fix

# python gateways_check.py basic
gw is [{u'gatewaysIps': u'10.135.126.254 169.254.0.1'}]
gwsList is [u'10.135.126.254', u'169.254.0.1']
All 2 gateways are reachable via ping

The output always returns 1 since all gateways are present in one line
but the actual output should be the number of gateways present
in that line
@boring-cyborg boring-cyborg Bot added component:virtual-router Python Warning... Python code Ahead! labels Apr 7, 2022
@yadvr yadvr added this to the 4.17.0.0 milestone Apr 7, 2022
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Apr 7, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3094

@Pearl1594
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3838)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33710 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6226-t3838-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_03_ssvm_internals Failure 13.94 test_ssvm.py

@yadvr yadvr merged commit d2aa13f into apache:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants