Skip to content

ui: Fix uploadCustomCertificate form in infraSummary view#6248

Merged
nvazquez merged 4 commits intoapache:mainfrom
shapeblue:fix-upload-custom-cert-form
Apr 12, 2022
Merged

ui: Fix uploadCustomCertificate form in infraSummary view#6248
nvazquez merged 4 commits intoapache:mainfrom
shapeblue:fix-upload-custom-cert-form

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Apr 12, 2022

Description

This PR fixes 2 issues:

  1. despite providing the privateKey i.e., pkcs form field, it isn't recognized
  2. on submitting the form, the handler function isn't invoked
    image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Successfully submits the form

@Pearl1594 Pearl1594 added this to the 4.17.0.0 milestone Apr 12, 2022
@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6248 (SL-JID-1364)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pearl1594 Please set the layout form to vertical and move the cancel/submit button to right?

@Pearl1594
Copy link
Copy Markdown
Contributor Author

Thanks @utchoang done

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6248 (SL-JID-1365)

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6248 (SL-JID-1366)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @Pearl1594

@weizhouapache
Copy link
Copy Markdown
Member

@Pearl1594 would it be better the messages are same ?

image

@Pearl1594
Copy link
Copy Markdown
Contributor Author

updated it @weizhouapache thanks!

@Pearl1594
Copy link
Copy Markdown
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6248 (SL-JID-1367)

@nvazquez nvazquez merged commit 6ec0137 into apache:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants