Skip to content

ui: Fix bulk deletion of ssh key pairs#6286

Merged
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:fix-ssh-group-action
Apr 20, 2022
Merged

ui: Fix bulk deletion of ssh key pairs#6286
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:fix-ssh-group-action

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR fixes the issue observed during bulk deletion of ssh key pairs where in it doesn't actually invoke the delete operation.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594 Pearl1594 requested review from nvazquez and utchoang April 19, 2022 13:58
@Pearl1594 Pearl1594 added this to the 4.17.0.0 milestone Apr 19, 2022
@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6286 (SL-JID-1404)

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested

@nvazquez nvazquez merged commit c339f6e into apache:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants