ui: Fix Internal LB LB rule column and missing translation#6288
Merged
nvazquez merged 1 commit intoapache:mainfrom Apr 20, 2022
Merged
ui: Fix Internal LB LB rule column and missing translation#6288nvazquez merged 1 commit intoapache:mainfrom
nvazquez merged 1 commit intoapache:mainfrom
Conversation
|
Found UI changes, kicking a new UI QA build |
|
Found Java/XML changes, kicking packaging job |
|
@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3228 |
PR Coverage Report
|
nvazquez
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR displays the load balancer rule in the internal LB list view which appears as an empty column, while the details view shows it.

vs

Also, there is a missing translation for a param field in the Add Internal LB form:

Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Goto http://:8080/#/ilb
And view the list view - where the lb rule is displayed:

Missing translation added:
