Skip to content

ui: Fix Internal LB LB rule column and missing translation#6288

Merged
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:fix-ilb-rule-translation
Apr 20, 2022
Merged

ui: Fix Internal LB LB rule column and missing translation#6288
nvazquez merged 1 commit intoapache:mainfrom
shapeblue:fix-ilb-rule-translation

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

Description

This PR displays the load balancer rule in the internal LB list view which appears as an empty column, while the details view shows it.
image

vs
image

Also, there is a missing translation for a param field in the Add Internal LB form:
image

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Goto http://:8080/#/ilb

  1. And view the list view - where the lb rule is displayed:
    image

  2. Missing translation added:
    image

@Pearl1594 Pearl1594 added this to the 4.17.0.0 milestone Apr 20, 2022
@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@acs-robot
Copy link
Copy Markdown

Found Java/XML changes, kicking packaging job
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3228

@acs-robot
Copy link
Copy Markdown

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
Volume 109 0 2 0 44 0
VolumeVO 529 133 4 0 179 39
VolumeObject 773 665 77 39 178 117
VmwareStorageProcessor 9892 9 940 0 2122 2
VolumeJoinDaoImpl 770 0 94 0 171 0
VolumeJoinVO 267 0 0 0 93 0
ConfigurationManagerImpl 18104 0 3032 0 3570 0
IpAddressManagerImpl 4045 0 461 0 806 0
ManagementServerImpl 11819 0 1052 0 2361 0
VolumeApiServiceImpl 10851 0 1500 0 2035 0
VirtualMachineMO 8953 135 1063 17 1982 31

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvazquez nvazquez merged commit 25f92c5 into apache:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants