Skip to content

UI: hide Virtual Routers tab for domain admins#6289

Merged
nvazquez merged 1 commit intoapache:mainfrom
weizhouapache:4.17-ui-hide-vr-tab
Apr 20, 2022
Merged

UI: hide Virtual Routers tab for domain admins#6289
nvazquez merged 1 commit intoapache:mainfrom
weizhouapache:4.17-ui-hide-vr-tab

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

Although domain admins are able to list routers by api, the Virtual Router tab was hidden in legacy UI for domain admins.
There are few issues with the page on UI, see #6191
Therefore hide the tab for domain admin in primate UI as well.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@acs-robot
Copy link
Copy Markdown

Found Java/XML changes, kicking packaging job
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache added this to the 4.17.0.0 milestone Apr 20, 2022
Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@weizhouapache weizhouapache linked an issue Apr 20, 2022 that may be closed by this pull request
@acs-robot
Copy link
Copy Markdown

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
Volume 109 0 2 0 44 0
VolumeVO 529 133 4 0 179 39
VolumeObject 773 665 77 39 178 117
VmwareStorageProcessor 9892 9 940 0 2122 2
VolumeJoinDaoImpl 770 0 94 0 171 0
VolumeJoinVO 267 0 0 0 93 0
ConfigurationManagerImpl 18104 0 3032 0 3570 0
IpAddressManagerImpl 4045 0 461 0 806 0
ManagementServerImpl 11819 0 1052 0 2361 0
VolumeApiServiceImpl 10851 0 1500 0 2035 0
VirtualMachineMO 8953 135 1063 17 1982 31

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3230

@nvazquez
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6289 (SL-JID-1411)

@nvazquez nvazquez merged commit 56fb7ac into apache:main Apr 20, 2022
@weizhouapache weizhouapache deleted the 4.17-ui-hide-vr-tab branch December 9, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

list routers issues by domain admin

6 participants