Skip to content

network: fix event, acl, firewall for ipv6 nw#6314

Merged
nvazquez merged 7 commits intoapache:mainfrom
shapeblue:fix-ipv6-routes
Apr 27, 2022
Merged

network: fix event, acl, firewall for ipv6 nw#6314
nvazquez merged 7 commits intoapache:mainfrom
shapeblue:fix-ipv6-routes

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Apr 26, 2022

Description

Fixes following with IPv6 networks:

  • Event resource for IPv6 firewall rules
  • radvd not running in single VR isolated network
  • IPv6 Firewall rules not added on the correct chain
  • IPv6 VPC tier ACL rules not added on the correct chain

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@acs-robot
Copy link
Copy Markdown

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
NetworkOfferingDaoImpl 701 0 24 0 118 0
ApiResponseHelper 12401 0 1292 0 2837 0
NetworkOfferingJoinDaoImpl 286 0 14 0 60 0
VpcOfferingJoinDaoImpl 180 0 8 0 39 0
CommandSetupHelper 4086 0 300 0 769 0

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>
@apache apache deleted a comment from blueorangutan Apr 26, 2022
@apache apache deleted a comment from acs-robot Apr 26, 2022
@apache apache deleted a comment from blueorangutan Apr 26, 2022
@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3309

@shwstppr
Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@acs-robot
Copy link
Copy Markdown

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
NetworkOfferingDaoImpl 701 0 24 0 118 0
ApiResponseHelper 12401 0 1292 0 2837 0
NetworkOfferingJoinDaoImpl 286 0 14 0 60 0
VpcOfferingJoinDaoImpl 180 0 8 0 39 0
CommandSetupHelper 4086 0 300 0 769 0

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 26, 2022
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually tested ok
(1) different ingress/egress chain for vpc tiers
(2) icmpv6 is always accepted between VR and VMs

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-4044)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56287 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6314-t4044-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_create_template_with_checksum_md5 Error 120.71 test_templates.py
test_05_create_template_with_no_checksum Error 65.44 test_templates.py

@nvazquez nvazquez marked this pull request as ready for review April 27, 2022 02:28
@nvazquez nvazquez merged commit e53ed9e into apache:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants