Skip to content

Disable creating StorPool logs when there isn't StorPool primary storage#6317

Merged
nvazquez merged 1 commit intoapache:mainfrom
storpool:stop-logging-storpool
Apr 27, 2022
Merged

Disable creating StorPool logs when there isn't StorPool primary storage#6317
nvazquez merged 1 commit intoapache:mainfrom
storpool:stop-logging-storpool

Conversation

@slavkap
Copy link
Copy Markdown
Contributor

@slavkap slavkap commented Apr 26, 2022

Description

There is no need to create log files for the StorPool driver when there
isn't a StorPool primary storage

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

There is not need to create log files for StorPool driver when there
isn't a StorPool primary storage
@nvazquez
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3310

@nvazquez
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 26, 2022
@acs-robot
Copy link
Copy Markdown

PR Coverage Report

CLASS INSTRUCTION MISSED INSTRUCTION COVERED BRANCH MISSED BRANCH COVERED LINE MISSED LINE COVERED
StorPoolAbandonObjectsCollector 259 0 28 0 44 0
StorPoolPrimaryDataStoreDriver 3215 0 242 0 531 0
StorPoolSnapshotStrategy 562 0 62 0 141 0

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-4045)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6317-t4045-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_verify_ipv6_network Failure 352.72 test_network_ipv6.py
test_02_verify_ipv6_network_redundant Failure 505.37 test_network_ipv6.py

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually tested without any Storpool pool and no logs added after storage operations

@nvazquez nvazquez merged commit 453bb57 into apache:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants