Fix UEFI detection on KVM and prevent deployments on non UEFI enabled hosts by nvazquez · Pull Request #6423 · apache/cloudstack

nvazquez · 2022-05-30T18:20:52Z

Description

This PR fixes 2 issues:

Prevent UEFI deployments on non UEFI enabled hosts (do not assume the host detail will always be present in case of not enabled)
Fix the UEFI detection on KVM (uefi.properties file check was missing)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested on KVM - one UEFI enabled host, one disabled

nvazquez · 2022-05-30T18:31:31Z

@blueorangutan package

nvazquez · 2022-05-30T18:37:55Z

@blueorangutan package

blueorangutan · 2022-05-30T18:39:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache

code lgtm

blueorangutan · 2022-05-30T19:16:24Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3503

nvazquez · 2022-05-30T23:45:04Z

@blueorangutan test

blueorangutan · 2022-05-30T23:46:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

sureshanaparti · 2022-05-31T07:39:32Z

        s_logger.debug("agent.hooks.libvirt_vm_on_stop.method is " + _agentHooksVmOnStopMethod);
    }

+    public boolean isUefiPropertiesFileSet() {


@nvazquez UEFI properties are loaded from this file while configuring the resource, no need to check again for this file, instead check for properties loaded or not. Also, re-use this method in loadUefiProperties() method below for the same condition. Thanks.

Suggested change

public boolean isUefiPropertiesFileSet() {

public boolean isUefiPropertiesLoaded() {

return _uefiProperties != null && _uefiProperties.getProperty("guest.loader.legacy") != null

}

Done, thanks - nice catch

Have actually simplified the check

nvazquez · 2022-05-31T09:57:48Z

@blueorangutan package

acs-robot · 2022-05-31T09:57:58Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-31T09:58:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-31T10:03:12Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1643)

nvazquez · 2022-05-31T10:16:28Z

@blueorangutan package

blueorangutan · 2022-05-31T10:17:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-05-31T10:58:05Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3507

nvazquez · 2022-05-31T11:07:49Z

@blueorangutan package

blueorangutan · 2022-05-31T11:09:03Z

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

acs-robot · 2022-05-31T11:09:10Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-31T11:10:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

acs-robot · 2022-05-31T11:12:17Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-05-31T11:13:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-05-31T11:20:28Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1644)

blueorangutan · 2022-05-31T11:23:26Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6423 (SL-JID-1645)

blueorangutan · 2022-05-31T11:25:49Z

Trillian test result (tid-4266)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40729 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6423-t4266-kvm-centos7.zip
Smoke tests completed. 86 look OK, 11 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_DeployVmAffinityGroup	`Error`	1.17	test_affinity_groups.py
test_DeployVmAntiAffinityGroup	`Error`	1.14	test_affinity_groups.py
ContextSuite context=TestDeployVM>:setup	`Error`	0.00	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	0.01	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	0.01	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	0.01	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	0.01	test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup	`Error`	2.67	test_vm_life_cycle.py
ContextSuite context=TestDeployVmWithAffinityGroup>:setup	`Error`	0.00	test_affinity_groups_projects.py
test_01_snapshot_root_disk	`Error`	907.68	test_snapshots.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	`Error`	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	`Error`	0.00	test_vpc_vpn.py
test_01_nic	`Error`	51.42	test_nic.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestLBRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestNatRuleUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestPublicIPUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestSnapshotUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVmUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVolumeUsage>:setup	`Error`	0.00	test_usage.py
ContextSuite context=TestVpnUsage>:setup	`Error`	0.00	test_usage.py
test_09_project_suspend	`Error`	1.07	test_projects.py
test_10_project_activation	`Error`	1.06	test_projects.py
ContextSuite context=TestRouterIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup	`Error`	0.00	test_routers_iptables_default_policy.py
ContextSuite context=TestVPCNics>:setup	`Error`	0.00	test_vpc_router_nics.py
test_01_cancel_host_maintenace_with_no_migration_jobs	`Error`	0.04	test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	0.04	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	`Error`	0.04	test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected	`Error`	0.01	test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected	`Error`	0.01	test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected	`Error`	0.01	test_host_maintenance.py

blueorangutan · 2022-05-31T11:56:45Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3508

sonarqubecloud · 2022-05-31T12:03:50Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

12.9% Coverage
0.0% Duplication

sureshanaparti

code LGTM

slavkap

code looks good

… hosts (apache#6423) (apache#221) * Do not allow UEFI deployments on non UEFI enabled hosts * Fix UEFI detection on KVM * Refactor * Improvement agent: Detect existing hosts with UEFI support (apache#6139) * agent: Pass uefi enabled status as part of ready command * Cleanup * Fix checkstyle * Save uefi status if different Co-authored-by: Marcus Sorensen <mls@apple.com>

nvazquez added 2 commits May 30, 2022 15:04

Do not allow UEFI deployments on non UEFI enabled hosts

a3809bd

Fix UEFI detection on KVM

a56ebbb

nvazquez added the type:bug label May 30, 2022

nvazquez added this to the 4.17.0.0 milestone May 30, 2022

nvazquez requested review from Pearl1594, slavkap and weizhouapache May 30, 2022 18:20

boring-cyborg Bot added the component:kvm label May 30, 2022

nvazquez requested review from davidjumani and yadvr May 30, 2022 18:31

weizhouapache approved these changes May 30, 2022

View reviewed changes

sureshanaparti reviewed May 31, 2022

View reviewed changes

Refactor

370aca0

Improvement

9be5241

nvazquez force-pushed the fixuefimismatch branch from f2663c9 to 9be5241 Compare May 31, 2022 11:10

sureshanaparti approved these changes May 31, 2022

View reviewed changes

slavkap approved these changes May 31, 2022

View reviewed changes

nvazquez merged commit 82e0d5d into apache:main May 31, 2022

-    public boolean isUefiPropertiesFileSet() {
+    public boolean isUefiPropertiesLoaded() {
+        return _uefiProperties != null && _uefiProperties.getProperty("guest.loader.legacy") != null
+    }

Conversation

nvazquez commented May 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

nvazquez commented May 30, 2022

Uh oh!

nvazquez commented May 30, 2022

Uh oh!

blueorangutan commented May 30, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented May 30, 2022

Uh oh!

nvazquez commented May 30, 2022

Uh oh!

blueorangutan commented May 30, 2022

Uh oh!

sureshanaparti May 31, 2022

Choose a reason for hiding this comment

Uh oh!

nvazquez May 31, 2022

Choose a reason for hiding this comment

Uh oh!

nvazquez May 31, 2022

Choose a reason for hiding this comment

Uh oh!

nvazquez commented May 31, 2022

Uh oh!

acs-robot commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

nvazquez commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

nvazquez commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

acs-robot commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

acs-robot commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

blueorangutan commented May 31, 2022

Uh oh!

sonarqubecloud Bot commented May 31, 2022

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

nvazquez commented May 30, 2022 •

edited

Loading