change-diskoffer: iops settings from new disk-offer should always used by rp- · Pull Request #6681 · apache/cloudstack

rp- · 2022-08-29T11:57:54Z

Description

If you had an disk-offer which would compute-only == false,
it wouldn't apply the iop settings of the new disk-offer and instead
use null for the settings.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Manually switching between the default 5GB disk offer and a self created IOP limiting disk offer.

codecov · 2022-08-29T12:37:54Z

Codecov Report

Merging #6681 (7704947) into main (9f7e0cc) will increase coverage by 4.54%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #6681      +/-   ##
============================================
+ Coverage      5.87%   10.42%   +4.54%     
- Complexity     3936     6696    +2760     
============================================
  Files          2454     2455       +1     
  Lines        242683   243143     +460     
  Branches      37978    38061      +83     
============================================
+ Hits          14265    25339   +11074     
+ Misses       226839   214635   -12204     
- Partials       1579     3169    +1590

Impacted Files	Coverage Δ
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	`10.79% <0.00%> (+10.79%)`	⬆️
...dstack/storage/datastore/PrimaryDataStoreImpl.java	`2.25% <0.00%> (-0.09%)`	⬇️
...visor/vmware/manager/VmwareStorageManagerImpl.java	`1.06% <0.00%> (-0.03%)`	⬇️
...ain/java/com/cloud/consoleproxy/AgentHookBase.java	`0.00% <0.00%> (ø)`
...n/java/com/cloud/resource/ResourceManagerImpl.java	`0.00% <0.00%> (ø)`
...ava/com/cloud/servlet/ConsoleProxyClientParam.java	`0.00% <0.00%> (ø)`
...va/com/cloud/consoleproxy/ConsoleProxyManager.java	`0.00% <0.00%> (ø)`
...ud/consoleproxy/AgentBasedConsoleProxyManager.java	`0.00% <0.00%> (ø)`
...oud/hypervisor/vmware/resource/VmwareResource.java	`0.00% <0.00%> (ø)`
...tack/engine/orchestration/NetworkOrchestrator.java	`0.00% <0.00%> (ø)`
... and 480 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

DaanHoogland · 2022-08-30T06:35:06Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs 0 Vulnerabilities 0 Security Hotspots 1 Code Smell

0.0% Coverage 0.0% Duplication

the code smell is 200 lines away from the nearest change in this PR and warants its own PR #notetomyself.

https://sonarcloud.io/code?id=apache_cloudstack&pullRequest=6681&selected=apache_cloudstack%3Aserver%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fstorage%2FVolumeApiServiceImpl.java&line=1762

https://sonarcloud.io/project/issues?pullRequest=6681&issues=AYLp8K4mOogROu0RKBAQ&open=AYLp8K4mOogROu0RKBAQ&id=apache_cloudstack

DaanHoogland

code looks good

JoaoJandre

CLGTM

If you had an disk-offer which would compute-only == false, it wouldn't apply the iop settings of the new disk-offer and instead use null for the settings.

acs-robot · 2022-09-14T09:28:31Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-09-14T09:29:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-09-14T09:34:05Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6681 (SL-JID-2355)

sonarqubecloud · 2022-09-14T10:38:07Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

rp- · 2022-09-21T10:14:19Z

is this good enough now?

DaanHoogland · 2022-09-21T10:29:04Z

@blueorangutan package

blueorangutan · 2022-09-21T10:30:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-09-21T11:12:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4236

DaanHoogland · 2022-09-21T12:53:53Z

@blueorangutan test matrix

blueorangutan · 2022-09-21T12:55:03Z

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2022-09-22T01:01:44Z

Trillian test result (tid-4954)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42104 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6681-t4954-kvm-centos7.zip
Smoke tests completed. 98 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.62	test_primary_storage.py
test_01_primary_storage_nfs	`Error`	0.11	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.20	test_primary_storage.py
test_01_secure_vm_migration	`Error`	157.18	test_vm_life_cycle.py
test_02_unsecure_vm_migration	`Error`	274.33	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	140.85	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	44.98	test_vm_life_cycle.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	34.29	test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster	`Failure`	64.22	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	41.36	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	40.20	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	129.01	test_kubernetes_clusters.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.51	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	8.51	test_snapshots.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	304.92	test_hostha_kvm.py

blueorangutan · 2022-09-22T02:41:02Z

Trillian test result (tid-4955)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48301 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6681-t4955-vmware-65u2.zip
Smoke tests completed. 103 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2022-09-22T19:33:04Z

Trillian test result (tid-4963)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45123 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6681-t4963-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	577.75	test_kubernetes_clusters.py

DaanHoogland · 2022-09-23T06:29:43Z

@blueorangutan test

blueorangutan · 2022-09-23T06:30:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-23T18:32:31Z

Trillian test result (tid-4981)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41910 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6681-t4981-kvm-centos7.zip
Smoke tests completed. 101 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	633.55	test_kubernetes_clusters.py
test_01_verify_ipv6_vpc	`Failure`	763.95	test_vpc_ipv6.py

boring-cyborg Bot added the component:storage label Aug 29, 2022

DaanHoogland reviewed Aug 29, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

rp- force-pushed the main-fix-disk-offering-iops branch from f29013f to 699bf69 Compare August 29, 2022 13:11

DaanHoogland approved these changes Aug 30, 2022

View reviewed changes

JoaoJandre approved these changes Sep 2, 2022

View reviewed changes

GutoVeronezi reviewed Sep 9, 2022

View reviewed changes

Comment thread server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java Outdated

change-diskoffer: always use iops settings from new disk-offer

7704947

If you had an disk-offer which would compute-only == false, it wouldn't apply the iop settings of the new disk-offer and instead use null for the settings.

rp- force-pushed the main-fix-disk-offering-iops branch from 699bf69 to 7704947 Compare September 14, 2022 09:26

yadvr added this to the 4.18.0.0 milestone Oct 8, 2022

yadvr merged commit eff10bc into apache:main Oct 8, 2022

rp- deleted the main-fix-disk-offering-iops branch February 5, 2024 08:38

Conversation

rp- commented Aug 29, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov Bot commented Aug 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

DaanHoogland commented Aug 30, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

JoaoJandre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

acs-robot commented Sep 14, 2022

Uh oh!

blueorangutan commented Sep 14, 2022

Uh oh!

blueorangutan commented Sep 14, 2022

Uh oh!

sonarqubecloud Bot commented Sep 14, 2022

Uh oh!

rp- commented Sep 21, 2022

Uh oh!

DaanHoogland commented Sep 21, 2022

Uh oh!

blueorangutan commented Sep 21, 2022

Uh oh!

blueorangutan commented Sep 21, 2022

Uh oh!

DaanHoogland commented Sep 21, 2022

Uh oh!

blueorangutan commented Sep 21, 2022

Uh oh!

blueorangutan commented Sep 22, 2022

Uh oh!

blueorangutan commented Sep 22, 2022

Uh oh!

blueorangutan commented Sep 22, 2022

Uh oh!

DaanHoogland commented Sep 23, 2022

Uh oh!

blueorangutan commented Sep 23, 2022

Uh oh!

blueorangutan commented Sep 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecov Bot commented Aug 29, 2022 •

edited

Loading