Remove unsupported params from API calls on the UI#6686
Merged
DaanHoogland merged 1 commit intoapache:mainfrom Aug 31, 2022
Merged
Remove unsupported params from API calls on the UI#6686DaanHoogland merged 1 commit intoapache:mainfrom
DaanHoogland merged 1 commit intoapache:mainfrom
Conversation
|
Found UI changes, kicking a new UI QA build |
|
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Codecov Report
@@ Coverage Diff @@
## main #6686 +/- ##
============================================
- Coverage 5.87% 5.87% -0.01%
+ Complexity 3936 3934 -2
============================================
Files 2454 2454
Lines 242683 242683
Branches 37978 37978
============================================
- Hits 14265 14261 -4
- Misses 226839 226843 +4
Partials 1579 1579
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
cc @shwstppr @DaanHoogland could cause potential regression as some APIs may require listall passed when account is not an admin account. Has anybody verified and tested this for normal account and domain admin if/wherever applicable? |
Member
|
cc @DaanHoogland milestone missing |
neogismm
pushed a commit
to neogismm/cloudstack
that referenced
this pull request
Sep 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the ACS has a lot of API call with unsupported parameters. While this does not cause any problems, as any unsupported parameters are discarded, there are a lot of messages with similar content:
WARN ... Received unknown parameters for command listZones. Unknown parameters : listall. Therefore, it can be confusing for beginner operators. Moreover, if the API does not support the parameter, it should not be used regardless.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This was tested in a local lab traversing the UI while monitoring the Management logs if there were any
WARN ... Received unknown parameters for command <API>. Unknown parameters : <param>.