Skip to content

UI: Remove incorrect API calls when initializing the deploy VM page#6687

Merged
yadvr merged 1 commit intoapache:4.17from
EWERK-DIGITAL:feature/fix-vm-fetch-api
Aug 30, 2022
Merged

UI: Remove incorrect API calls when initializing the deploy VM page#6687
yadvr merged 1 commit intoapache:4.17from
EWERK-DIGITAL:feature/fix-vm-fetch-api

Conversation

@utchoang
Copy link
Copy Markdown

@utchoang utchoang commented Aug 30, 2022

Description

This PR is used to fix the error that an unknown API call appeared when initializing the deploy VM page.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

image

How Has This Been Tested?

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6687 (SL-JID-2249)

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 30, 2022

Codecov Report

Merging #6687 (a53a33b) into 4.17 (7115e35) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.17    #6687      +/-   ##
============================================
- Coverage      5.86%    5.86%   -0.01%     
+ Complexity     3920     3918       -2     
============================================
  Files          2451     2451              
  Lines        242282   242282              
  Branches      37911    37911              
============================================
- Hits          14211    14207       -4     
- Misses       226501   226505       +4     
  Partials       1570     1570              
Impacted Files Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java 56.49% <0.00%> (-2.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr shwstppr requested review from Pearl1594 and yadvr August 30, 2022 07:57
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr added this to the 4.17.1.0 milestone Aug 30, 2022
@yadvr yadvr merged commit 3170338 into apache:4.17 Aug 30, 2022
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
weizhouapache added a commit that referenced this pull request Sep 7, 2022
ui: fix zone icon in vm deploy zone selection (#6543)
ui: remove incorrect API calls when initializing the deploy VM page (#6687)
ui: Fix netowrkid not passed in deployvm (#6711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants