Ignore opensaml's slf4j dependencies#6693
Conversation
GutoVeronezi
changed the title
|
@GutoVeronezi good find, can you edit PR base to 4.17 and rebase your PR branch to 4.17? |
boring-cyborg
Bot
added
component:agent
component:api
Python
GutoVeronezi
force-pushed
the
fix-logging-problem-on-agents-and-usage
branch
from
b13f79a to
b7bb44e
Compare
|
Found UI changes, kicking a new UI QA build |
|
@blueorangutan package |
|
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report
@@ Coverage Diff @@
## 4.17 #6693 +/- ##
=======================================
Coverage ? 5.87%
Complexity ? 3918
=======================================
Files ? 2451
Lines ? 242282
Branches ? 37911
=======================================
Hits ? 14223
Misses ? 226488
Partials ? 1571 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4091 |
|
@blueorangutan test |
|
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Trillian test result (tid-4784)
|
|
@GutoVeronezi I tried reproducing agent logs issue but don't see any error there in a main branch env. KVM hosts are, Am I missing anything? |
yadvr
left a comment
yadvr
left a comment
There was a problem hiding this comment.
LGTM - needs testing (maybe as simple as before this PR do we see slf4j jars say in the kvm/ssvm/cpvm agent and if those are then not seen with this PR)
|
@shwstppr if @GutoVeronezi isn't responding, I don't see any harm in merging this - you can atleast regression test and check logs on ssvm/cpvm/kvm agents. |
|
OKay @rohityadavcloud. I'll verify for any regressions today |
|
Verified logging on systemvms and hosts with following config:
|
|
@shwstppr, sorry for the delay. The occurence of this error depends on how Java loads the four libraries mentioned. The classpath is defined as We upgraded more than 40 services (Agents and Usages - in CentOS 7 and Ubuntu 20.04) to the opensaml upgrade patch and around 10 presented the error (around 25%), meaning that most of the time the libraries are loaded correctly; however, sometimes they are loaded in a different order that causes the error. Due to lack of time we could not find the specificity that triggers the loading order difference between the environments; however, we do understand that they are caused by the dependencies introduced with the new opensaml version. |
Fixes apache#194 Commit f27de63 introduced a new version of opensaml. That version brought jcl-over-slf4j-1.7.5.jar, jul-to-slf4j-1.7.5.jar, and log4j-over-slf4j-1.7.5.jar as dependencies, which causes Agents and Usages to not generate logs. In order to make the logs to work again, this PR intends to exclude these dependencies while building the packages. (cherry picked from commit e76df16) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
6 participants
Description
Commit f27de63 introduced a new version of opensaml. That version brought
jcl-over-slf4j-1.7.5.jar,jul-to-slf4j-1.7.5.jar, andlog4j-over-slf4j-1.7.5.jaras dependencies, which causes Agents and Usages to not generate logs:In order to make the logs to work again, this PR intends to exclude these dependencies while building the packages.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
After applying the commit f27de63, the logs on the Agents and Usages stopped being written. After applying this PR, the logs started to be written again.