Skip to content

UI: fix bulk delete project with cleanup#6708

Merged
shwstppr merged 1 commit intoapache:4.17from
weizhouapache:4.17-fix-delete-project-cleanup
Sep 7, 2022
Merged

UI: fix bulk delete project with cleanup#6708
shwstppr merged 1 commit intoapache:4.17from
weizhouapache:4.17-fix-delete-project-cleanup

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes an UI issue that cleanup parameter is not passed when bulk-delete projects.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 6, 2022

Codecov Report

Merging #6708 (fa3469d) into 4.17 (e76df16) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.17    #6708      +/-   ##
============================================
- Coverage      5.88%    5.87%   -0.01%     
+ Complexity     3928     3927       -1     
============================================
  Files          2451     2451              
  Lines        242312   242312              
  Branches      37920    37920              
============================================
- Hits          14255    14246       -9     
- Misses       226481   226492      +11     
+ Partials       1576     1574       -2     
Impacted Files Coverage Δ
...rg/apache/cloudstack/quota/QuotaStatementImpl.java 36.28% <0.00%> (-3.99%) ⬇️
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java 62.30% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented Sep 6, 2022

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested network requests cleanup param was passed with the change,

Before,
Screenshot from 2022-09-06 18-05-47

After,
Screenshot from 2022-09-06 18-15-54

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shwstppr shwstppr added this to the 4.17.1.0 milestone Sep 7, 2022
@shwstppr shwstppr merged commit fe16be0 into apache:4.17 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants