Skip to content

fix test_acl_sharenetworks from components#7031

Closed
DaanHoogland wants to merge 7 commits intoapache:mainfrom
shapeblue:testAclSharedNetworks-fix
Closed

fix test_acl_sharenetworks from components#7031
DaanHoogland wants to merge 7 commits intoapache:mainfrom
shapeblue:testAclSharedNetworks-fix

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Dec 28, 2022

Description

This PR... has some problems. It contains a good enhancement of the cloudstackTestCase, but a lot of tests depend on it not being there. creating a new PR with only the revert.
see #7033

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@boring-cyborg boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Dec 28, 2022
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Dec 28, 2022
@weizhouapache
Copy link
Copy Markdown
Member

@blueorangutan package

@weizhouapache
Copy link
Copy Markdown
Member

@DaanHoogland there is a lint check error

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5121

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 28, 2022

Codecov Report

Merging #7031 (1f8684f) into main (c4b444d) will decrease coverage by 1.38%.
The diff coverage is n/a.

❗ Current head 1f8684f differs from pull request most recent head f0892ef. Consider uploading reports for the commit f0892ef to get more accurate results

@@             Coverage Diff              @@
##               main    #7031      +/-   ##
============================================
- Coverage     12.69%   11.31%   -1.38%     
+ Complexity     8655     7332    -1323     
============================================
  Files          2716     2494     -222     
  Lines        256117   246787    -9330     
  Branches      39927    38533    -1394     
============================================
- Hits          32503    27929    -4574     
+ Misses       219482   215260    -4222     
+ Partials       4132     3598     -534     
Impacted Files Coverage Δ
...c/main/java/com/cloud/projects/ProjectManager.java 0.00% <0.00%> (-100.00%) ⬇️
.../main/java/com/cloud/configuration/ZoneConfig.java 0.00% <0.00%> (-82.15%) ⬇️
.../cloudstack/api/response/QuotaSummaryResponse.java 0.00% <0.00%> (-67.57%) ⬇️
.../schema/src/main/java/com/cloud/host/DetailVO.java 15.38% <0.00%> (-53.85%) ⬇️
...ck/engine/service/api/ProvisioningServiceImpl.java 0.00% <0.00%> (-51.12%) ⬇️
...apache/cloudstack/resourcedetail/UserDetailVO.java 0.00% <0.00%> (-40.00%) ⬇️
...in/java/org/apache/cloudstack/backup/BackupVO.java 40.00% <0.00%> (-37.50%) ⬇️
...com/cloud/agent/manager/ConnectedAgentAttache.java 0.00% <0.00%> (-37.50%) ⬇️
...k/engine/datacenter/entity/api/ZoneEntityImpl.java 0.00% <0.00%> (-30.19%) ⬇️
...k/engine/datacenter/entity/api/HostEntityImpl.java 0.00% <0.00%> (-29.10%) ⬇️
... and 484 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment thread tools/marvin/marvin/cloudstackTestCase.py Outdated
@DaanHoogland
Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5137

@DaanHoogland DaanHoogland removed this from the 4.18.0.0 milestone Dec 30, 2022
@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

Too many other tests are suffering from this solution. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants