Allow download of System VM templates through the UI#7039
Merged
DaanHoogland merged 1 commit intoapache:mainfrom Jan 4, 2023
Merged
Allow download of System VM templates through the UI#7039DaanHoogland merged 1 commit intoapache:mainfrom
DaanHoogland merged 1 commit intoapache:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7039 +/- ##
=========================================
Coverage 11.54% 11.54%
- Complexity 7519 7520 +1
=========================================
Files 2494 2494
Lines 246787 246787
Branches 38533 38533
=========================================
+ Hits 28480 28489 +9
+ Misses 214626 214616 -10
- Partials 3681 3682 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
stephankruggg
approved these changes
Jan 3, 2023
yadvr
approved these changes
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR#6750 allowed Root Admins to download system VM templates through the API. This function was extended to the UI.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
Before applying the changes:
After applying the changes:
I opened the instance menu with a Root Admin account and checked that the download button was available.
I opened the instance menu with a non-Root Admin account and checked that the download button was not available.