Skip to content

Added upper case JPEG extension for icon upload#7200

Merged
DaanHoogland merged 2 commits intoapache:4.18from
kiranchavala:kiran_ui
Mar 30, 2023
Merged

Added upper case JPEG extension for icon upload#7200
DaanHoogland merged 2 commits intoapache:4.18from
kiranchavala:kiran_ui

Conversation

@kiranchavala
Copy link
Copy Markdown
Member

Description

This PR updates the file UploadResourceIcon.vue in directory ui/src/components/view

Currently if a file contains Captial JPEG extension, the icon fails to upload

Changed line number 198 to include capital JPEG extension

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

UI

How Has This Been Tested?

Comment thread ui/src/components/view/UploadResourceIcon.vue Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2023

Codecov Report

Merging #7200 (2697e4b) into main (dcf01f7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7200      +/-   ##
============================================
- Coverage     12.67%   12.67%   -0.01%     
  Complexity     8641     8641              
============================================
  Files          2716     2716              
  Lines        256112   256112              
  Branches      39926    39926              
============================================
- Hits          32465    32461       -4     
- Misses       219517   219522       +5     
+ Partials       4130     4129       -1     
Impacted Files Coverage Δ
...dstack/network/contrail/model/ModelObjectBase.java 28.84% <0.00%> (-15.39%) ⬇️
...cloudstack/network/contrail/model/ModelObject.java 29.16% <0.00%> (-4.17%) ⬇️
...com/cloud/agent/manager/ConnectedAgentAttache.java 37.50% <0.00%> (+12.50%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Comment thread ui/src/components/view/UploadResourceIcon.vue Outdated
Comment thread ui/src/components/view/UploadResourceIcon.vue Outdated
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland
Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7200 (QA-JID-52)

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried several mixed case image extension in qa (pNg and jpEg) as well as some regular lower case ones.

@DaanHoogland
Copy link
Copy Markdown
Contributor

@jbampton can you approve?

@DaanHoogland DaanHoogland added this to the 4.18.1.0 milestone Mar 2, 2023
Copy link
Copy Markdown
Contributor

@stephankruggg stephankruggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM, not manually tested

@kiranchavala
Copy link
Copy Markdown
Member Author

I manually tested it and it works

@harikrishna-patnala @shwstppr can you review and approve

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranchavala you may update the PR title to something more suitable

@shwstppr
Copy link
Copy Markdown
Contributor

Also, can we have it in 4.18 branch?

@DaanHoogland DaanHoogland changed the base branch from main to 4.18 March 30, 2023 20:04
@DaanHoogland DaanHoogland merged commit fcf07f1 into apache:4.18 Mar 30, 2023
kishankavala pushed a commit to shapeblue/cloudstack that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants