Skip to content

server: dedicate vxlan range to account#7215

Merged
yadvr merged 1 commit intoapache:4.17from
weizhouapache:4.17-dedicate-vxlan-range
Apr 19, 2023
Merged

server: dedicate vxlan range to account#7215
yadvr merged 1 commit intoapache:4.17from
weizhouapache:4.17-dedicate-vxlan-range

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR fixes #6871

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@weizhouapache weizhouapache linked an issue Feb 14, 2023 that may be closed by this pull request
@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5574

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.9% 38.9% Coverage
0.0% 0.0% Duplication

@kiranchavala
Copy link
Copy Markdown
Member

@blueorangutan ui

@kiranchavala
Copy link
Copy Markdown
Member

@blueorangutan help

@blueorangutan
Copy link
Copy Markdown

@kiranchavala I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv]
Mgmt OS options: ['centos7', 'centos6', 'suse15', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'rocky8', 'alma9']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'nvazquez', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'rahulbcn27', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'weizhouapache', 'NuxRo', 'mlsorensen']

@kiranchavala
Copy link
Copy Markdown
Member

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7215 (QA-JID-59)

@kiranchavala
Copy link
Copy Markdown
Member

@weizhouapache

Tested the issue LGTM

was able to dedicate vxlan range to an account

on 4.17.2 - exception

vxaln

On PR build

vxaln2

@weizhouapache weizhouapache added this to the 4.18.1.0 milestone Mar 2, 2023
@weizhouapache
Copy link
Copy Markdown
Member Author

thanks @kiranchavala for the testing

added to 4.18.1.0 milestone . cc @DaanHoogland

@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5905

@shwstppr
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-6407)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37585 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7215-t6407-kvm-centos7.zip
Smoke tests completed. 98 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_02_deploy_vm_with_extraconfig_kvm Error 0.15 test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm Error 0.14 test_deploy_vm_extra_config_data.py
test_08_upgrade_kubernetes_ha_cluster Failure 623.51 test_kubernetes_clusters.py
test_02_deploy_vm_on_specific_cluster Error 1.14 test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod Error 1.17 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 1.16 test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod Error 0.13 test_vm_deployment_planner.py

@shwstppr shwstppr requested review from DaanHoogland and yadvr April 13, 2023 04:16
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did n't test it, but logical changes LGTM

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Apr 19, 2023

Test failures not related to this PR. Merging this.

@yadvr yadvr merged commit fb51504 into apache:4.17 Apr 19, 2023
@weizhouapache weizhouapache deleted the 4.17-dedicate-vxlan-range branch June 23, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guest Network - Dedicated VXLAN Range

6 participants