Fix Quota plugin state on QuotaSummaryResponse

[BryanMLima]

Description

This PR aims to fix a feature introduced in PR#6690. It was added the parameter quotaenabled to the response of the Quota Summary API. However, this parameter was not set, and thus, always returned false. This PR fix this behavior, returning the correct value according to the configuration value.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

This was tested in a local lab with user dom01 with the Quota plugin enabled and with user dom02 with the plugin disabled. The image below presents the correct behavior for Quota summary response.

[BryanMLima]

Hey @DaanHoogland, this is the one line PR fix mentioned in the mailing list.

[DaanHoogland]

Looks trivial @BryanMLima . Is this covered by an existing test? Or can we add a trivial test or assert somewhere?

[codecov]

Codecov Report

Merging #7257 (ab7a8a8) into main (597a803) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #7257      +/-   ##
============================================
+ Coverage     12.67%   12.69%   +0.01%     
- Complexity     8639     8655      +16     
============================================
  Files          2716     2716              
  Lines        256112   256112              
  Branches      39926    39926              
============================================
+ Hits          32456    32503      +47     
+ Misses       219528   219477      -51     
- Partials       4128     4132       +4     

Impacted Files	Coverage Δ
...udstack/api/response/QuotaResponseBuilderImpl.java	39.05% <100.00%> (+5.22%)	⬆️
...ervisor/kvm/resource/LibvirtComputingResource.java	18.30% <0.00%> (-0.04%)	⬇️
...com/cloud/agent/manager/ConnectedAgentAttache.java	37.50% <0.00%> (+12.50%)	⬆️
.../cloudstack/api/response/QuotaSummaryResponse.java	67.56% <0.00%> (+67.56%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stephankruggg]

CLGTM, not manually tested

[yadvr]

Didn't check/test this, but clgtm

[DaanHoogland]

@BryanMLima , I'd love to add this but at this stage I really want some prove included

Looks trivial @BryanMLima . Is this covered by an existing test? Or can we add a trivial test or assert somewhere?

[BryanMLima]

@BryanMLima , I'd love to add this but at this stage I really want some prove included

Looks trivial @BryanMLima . Is this covered by an existing test? Or can we add a trivial test or assert somewhere?

Sorry for the delay, I am taking a look in to this. I will probably add a integration test in test_quota.py.

[DaanHoogland]

@BryanMLima , I'd love to add this but at this stage I really want some prove included

Looks trivial @BryanMLima . Is this covered by an existing test? Or can we add a trivial test or assert somewhere?

Sorry for the delay, I am taking a look in to this. I will probably add a integration test in test_quota.py.

seems like overkill for this @BryanMLima . As only a response field is added it would suffice to assert its presence in an existing test.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5627